ICEfaces
  1. ICEfaces
  2. ICE-10690

Showcase -> mobi:cloudPush demo has button state problems on iOS

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Minor Minor
          • Resolution: Won't Fix
          • Affects Version/s: EE-4.0.0.GA
          • Fix Version/s: EE-4.2.0.GA
          • Component/s: MOBI-Components, Sample Apps
          • Labels:
            None
          • Environment:
            ICEfaces 4, showcase app, mobi:cloudPush demo, iOS device
          • Assignee Priority:
            P1

            Description

            When running the cloud push demo on the showcase on an iOS device, once you receive a native cloud push notification the demo always displays the "Enable Cloud Push" button, even immediately after clicking it.

            To reproduce:

            1. Use icefaces-showcase.icesoft.org (this has native notifications working)
            2. Navigate to the Cloud Push demo on a mobile device
            3. Click EnableCloud Push button
            4. Click Disconnect Push button
            5. Click Priority Push button
            6. Wait for the native notification to arrive. When it does, click it to navigate back to the demo in the browser.
            7. See that the Enable Cloud Push button is rendered again (incorrectly).
            8. Click Enable Cloud Push button. (see that when it returns to the browser the Enable Cloud Push button is still rendered).
            9. At this point, if you touch the browser in the white-space beside the Enable Cloud Push button, the correct buttons will display (or if you close the browser tab and re-open and start from scratch)

              Issue Links

              depends on

              New Feature - A new feature of the product, which has yet to be developed. PUSH-398 Modify ICEpush bridge to use add/remove/has/NotifyBackURI functions

              • Major - Major loss of function.
              • Resolved

                Activity

                Ascending order - Click to sort in descending order
                Ken Fyten created issue -
                Ken Fyten made changes -
                Field Original Value New Value
                Fix Version/s 4.1 [ 11375 ]
                Ken Fyten made changes -
                Environment ICEfaces 4, showcase app, mobi:cloudPush demo ICEfaces 4, showcase app, mobi:cloudPush demo, iOS device
                Ken Fyten made changes -
                Summary Showcase -> mobi:cloudPush demo has button state problems Showcase -> mobi:cloudPush demo has button state problems on iOS
                Ken Fyten made changes -
                Description When running the cloud push demo on the showcase, once you receive a native cloud push notification the demo always displays the "Enable Cloud Push" button, even immediately after clicking it.

                To reproduce:

                1. Use icefaces-showcase.icesoft.org (this has native notifications working)
                2. Navigate to the Cloud Push demo on a mobile device
                3. Click EnableCloud Push button
                4. Click Disconnect Push button
                5. Click Priority Push button
                6. Wait for the native notification to arrive. When it does, click it to navigate back to the demo in the browser.
                7. See that the Enable Cloud Push button is rendered again (incorrectly).
                8. Click Enable Cloud Push button. (see that when it returns to the browser the Enable Cloud Push button is still rendered).
                9. At this point, the only way to get rid of the Enable Cloud Push button is close the browser window and restart.

                		When running the cloud push demo on the showcase on an iOS device, once you receive a native cloud push notification the demo always displays the "Enable Cloud Push" button, even immediately after clicking it.

                To reproduce:

                1. Use icefaces-showcase.icesoft.org (this has native notifications working)
                2. Navigate to the Cloud Push demo on a mobile device
                3. Click EnableCloud Push button
                4. Click Disconnect Push button
                5. Click Priority Push button
                6. Wait for the native notification to arrive. When it does, click it to navigate back to the demo in the browser.
                7. See that the Enable Cloud Push button is rendered again (incorrectly).
                8. Click Enable Cloud Push button. (see that when it returns to the browser the Enable Cloud Push button is still rendered).
                9. At this point, if you touch the browser in the white-space beside the Enable Cloud Push button, the correct buttons will display (or if you close the browser tab and re-open and start from scratch)
                Ken Fyten made changes -
                Assignee Judy Guglielmin [ judy.guglielmin ]
                Priority Major [ 3 ] Minor [ 4 ]
                Assignee Priority P2 [ 10011 ]
                Ken Fyten made changes -
                Link This issue depends on ICE-10789 [ ICE-10789 ]
                Ken Fyten made changes -
                Assignee Priority P2 [ 10011 ]
                Fix Version/s EE-4.1.0.GA [ 12171 ]
                Fix Version/s 4.1 [ 11375 ]
                Judy Guglielmin made changes -
                Link This issue depends on ICE-10789 [ ICE-10789 ]
                Ken Fyten made changes -
                Fix Version/s 4.1 [ 11375 ]
                Fix Version/s EE-4.1.0.GA [ 12171 ]
                Ken Fyten made changes -
                Fix Version/s EE-4.1.0.GA [ 12171 ]
                Fix Version/s 4.1 [ 11375 ]
                Ken Fyten made changes -
                Link This issue depends on PUSH-398 [ PUSH-398 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                This issue has been addressed via additional integration with new APIs introduced in PUSH-398.

                Show
                Ken Fyten added a comment - This issue has been addressed via additional integration with new APIs introduced in PUSH-398 .
                Ken Fyten made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Fix Version/s EE-4.1.0.BETA [ 13072 ]
                Ken Fyten made changes -
                Fix Version/s EE-4.1.1.BETA [ 13079 ]
                Fix Version/s EE-4.1.0.GA [ 12171 ]
                Fix Version/s EE-4.1.0.RC1 [ 13072 ]
                Carmen Cristurean made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Ken Fyten made changes -
                Assignee Judy Guglielmin [ judy.guglielmin ] Mircea Toma [ mircea.toma ]
                Ken Fyten made changes -
                Assignee Priority P1 [ 10010 ]
                Hide
                Permalink
                Mircea Toma added a comment -

                Modified CloudPushRenderer to render button only when cloud push was not yet enabled. The renderer makes use of the new PushContext.hasNotifyBackURI to determine when to render the button.

                Show
                Mircea Toma added a comment - Modified CloudPushRenderer to render button only when cloud push was not yet enabled. The renderer makes use of the new PushContext.hasNotifyBackURI to determine when to render the button.
                Mircea Toma made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #48830 Thu May 19 11:32:28 MDT 2016 mircea.toma ICE-10690 Modified renderer to render button only when cloud push was not yet enabled.
                Files Changed
                Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/cloudpush/CloudPushRenderer.java
                Carmen Cristurean made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Hide
                Permalink
                Mircea Toma added a comment -

                Applied fixes to 4.1.1 BETA branch.

                Show
                Mircea Toma added a comment - Applied fixes to 4.1.1 BETA branch.
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #48835 Mon May 23 06:40:52 MDT 2016 mircea.toma ICE-10690 Remove client side state tracking of the mobi:cloudPush button.
                Files Changed
                Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/mobi/cloudpush/cloudpush-example.xhtml
                Hide
                Permalink
                Carmen Cristurean added a comment - - edited

                The fix applied on both EE4 trunk and EE 4.1.1.BETA tag causes the regression described above: after enabling Cloud Push, the "Priority Push" and "Simple Push" buttons fail to remain rendered. This occurs on desktop and mobile devices.
                Also, starting at this code revision, the "Enable Cloud Push" button, when rendered, is left-aligned (desktop browsers only). Screen shot attached.

                Showcase from EE4 trunk r48837 and EE-4.1.1.BETA tag r48837 are deployed on Labs1, and this issue can be reproduced on them:
                http://54.245.237.240/tomcat-1/showcase/showcase-mobile.jsf
                http://54.245.237.240/tomcat-1/showcase-B/showcase-mobile.jsf

                Show
                Carmen Cristurean added a comment - - edited The fix applied on both EE4 trunk and EE 4.1.1.BETA tag causes the regression described above: after enabling Cloud Push, the "Priority Push" and "Simple Push" buttons fail to remain rendered. This occurs on desktop and mobile devices. Also, starting at this code revision, the "Enable Cloud Push" button, when rendered, is left-aligned (desktop browsers only). Screen shot attached. Showcase from EE4 trunk r48837 and EE-4.1.1.BETA tag r48837 are deployed on Labs1, and this issue can be reproduced on them: http://54.245.237.240/tomcat-1/showcase/showcase-mobile.jsf http://54.245.237.240/tomcat-1/showcase-B/showcase-mobile.jsf
                Carmen Cristurean made changes -
                Attachment EnableCloudPush.PNG [ 22209 ]
                Hide
                Permalink
                Mircea Toma added a comment -

                Make "Simple Push" and "Priority Push" buttons always visible. Add CSS style to mobi:cloudPush button.

                Show
                Mircea Toma added a comment - Make "Simple Push" and "Priority Push" buttons always visible. Add CSS style to mobi:cloudPush button.
                Mircea Toma made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #48839 Tue May 24 05:13:47 MDT 2016 mircea.toma ICE-10690 Make "Simple Push" and "Priority Push" buttons always visible. Add CSS style to mobi:cloudPush button.
                Files Changed
                Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/mobi/cloudpush/cloudpush-example.xhtml
                Carmen Cristurean made changes -
                Attachment EnableCloudPush-rev48841.PNG [ 22210 ]
                Ken Fyten made changes -
                Assignee Mircea Toma [ mircea.toma ] Ken Fyten [ ken.fyten ]
                Hide
                Permalink
                Ken Fyten added a comment -

                Re-opened to review cloud push showcase demo in light of new Cloud Push demo app.

                Show
                Ken Fyten added a comment - Re-opened to review cloud push showcase demo in light of new Cloud Push demo app.
                Ken Fyten made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Hide
                Permalink
                Liana Munroe added a comment -

                ICEfaces EE-4.1.0.GA Jenkins build 2 - Verified roll back for "Modified CloudPushRenderer to render button only when cloud push was not yet enabled." ios ipad 9.3

                Show
                Liana Munroe added a comment - ICEfaces EE-4.1.0.GA Jenkins build 2 - Verified roll back for "Modified CloudPushRenderer to render button only when cloud push was not yet enabled." ios ipad 9.3
                Ken Fyten made changes -
                Fix Version/s EE-4.2.0.GA [ 13071 ]
                Fix Version/s EE-4.1.1.BETA [ 13079 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                Closing as Won't Fix as Cloud Push support is not supported.

                Show
                Ken Fyten added a comment - Closing as Won't Fix as Cloud Push support is not supported.
                Ken Fyten made changes -
                Status Reopened [ 4 ] Closed [ 6 ]
                Resolution Won't Fix [ 2 ]

                  People

                  • Assignee:
                    Ken Fyten
                    Reporter:
                    Ken Fyten
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    5 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: