ICEfaces
  1. ICEfaces
  2. ICE-10682

ace:fileEntry - ice.ace.fileentry.onchange is not a function error

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P02
          • Fix Version/s: EE-3.3.0.GA_P04
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            When using autoUpload=true, the following error is thrown in the console and the upload doesn't happen once the file is selected:

            ice.ace.fileentry.onchange is not a function

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Hide
              Permalink
              Arran Mccullough added a comment -

              To reproduce set autoUpload=true on the ace:fileEntry component.

              Show
              Arran Mccullough added a comment - To reproduce set autoUpload=true on the ace:fileEntry component.
              Ken Fyten made changes -
              Field Original Value New Value
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Fix Version/s EE-3.3.0.GA_P04 [ 12270 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ]
              Ken Fyten made changes -
              Assignee Priority P2 [ 10011 ]
              Arturo Zambrano made changes -
              Fix Version/s 4.1 [ 11375 ]
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Removing 4.1 as fix target, since I couldn't reproduce the issue on the showcase. I verified that the onchange function exists in the client-side code. However, it doesn't exist in the 3.3 maintenance branch. It seems like the autoupload feature wasn't actually implemented in 3.3.

              Testing notes: please confirm that there's no issue with the 4.0 code.

              Show
              Arturo Zambrano added a comment - Removing 4.1 as fix target, since I couldn't reproduce the issue on the showcase. I verified that the onchange function exists in the client-side code. However, it doesn't exist in the 3.3 maintenance branch. It seems like the autoupload feature wasn't actually implemented in 3.3. Testing notes: please confirm that there's no issue with the 4.0 code.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              The autoUpload feature wasn't targeted for 3.3 (ICE-6637), but at some point it was backported when backporting the support for Servlet 3 multi-part uploads (ICE-9273, r40315). This commit also included some code for the multiple file upload mode, even though it wasn't targeted for 3.3 either. The 'multiple' attribute also exists in 3.3 but it causes an error when trying to use it.

              The autoupload issue is easily fixed by simply reverting the Javascript code to a simpler script that was used before supporting multiple file uploads. However, the 'multiple' attribute would stay there, potentially causing issues. We could simply remove that attribute or we could try and add support for the multiple file upload mode, which would require backporting ICE-6204 and all subsequent fixes and improvements to the multiple file upload mode.

              Show
              Arturo Zambrano added a comment - The autoUpload feature wasn't targeted for 3.3 ( ICE-6637 ), but at some point it was backported when backporting the support for Servlet 3 multi-part uploads ( ICE-9273 , r40315). This commit also included some code for the multiple file upload mode, even though it wasn't targeted for 3.3 either. The 'multiple' attribute also exists in 3.3 but it causes an error when trying to use it. The autoupload issue is easily fixed by simply reverting the Javascript code to a simpler script that was used before supporting multiple file uploads. However, the 'multiple' attribute would stay there, potentially causing issues. We could simply remove that attribute or we could try and add support for the multiple file upload mode, which would require backporting ICE-6204 and all subsequent fixes and improvements to the multiple file upload mode.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r48820: fixed 'autoUpload' attribute; removed 'multiple' attribute

              Testing notes: please run all regression tests, paying special attention to ICE-9273.

              Show
              Arturo Zambrano added a comment - r48820: fixed 'autoUpload' attribute; removed 'multiple' attribute Testing notes: please run all regression tests, paying special attention to ICE-9273 .
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces 4 trunk, ee-3.3.0 maintenance branch r48851. Chrome 50, FF 43, IE 11.
              The multiple attribute was removed from the ee-3.3.0 fileEntryDynAttribute test.

              Show
              Liana Munroe added a comment - Verified ICEfaces 4 trunk, ee-3.3.0 maintenance branch r48851. Chrome 50, FF 43, IE 11. The multiple attribute was removed from the ee-3.3.0 fileEntryDynAttribute test.
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: