ICEfaces
  1. ICEfaces
  2. ICE-10670

showcase ace:dataTable Row State and Row/Cell Editing fail when DeltaSubmit=true

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P01
    • Fix Version/s: EE-3.3.0.GA_P03, 4.1
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      Tomcat 7, all browsers, deltaSubmit=true, showcase dataTable > Row State, Row/Cell editing demos
    • Assignee Priority:
      P1

      Description

      showcase dataTable > Row State, Row/Cell editing demos
      After editing a cell and submitting changes the new input is reverted back to the original value.

        Activity

        Liana Munroe created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee Arturo Zambrano [ artzambrano ]
        Fix Version/s EE-3.3.0.GA_P03 [ 11572 ]
        Assignee Priority P1 [ 10010 ]
        Hide
        Arturo Zambrano added a comment -

        After substantial investigation, it's still not clear what exactly is causing this issue. This issue can also be seen in the P02, P01 and the original 3.3.0 release in the Row State demo only when enabling rows for editing by clicking the buttons above the table. The requests made when deltaSubmit=true are correct, and they contain the new values entered when editing, but in the decoding phase the submitted value (retrieved from the request parameters map, using the component's client id as a key) is always the previous value, and not what was edited in the text field and sent in the request. This also occurs with other input components. It seems like the internal mechanism used by delta submit to compare previous values is reverting the values sent in the request, under certain scenarios.

        Show
        Arturo Zambrano added a comment - After substantial investigation, it's still not clear what exactly is causing this issue. This issue can also be seen in the P02, P01 and the original 3.3.0 release in the Row State demo only when enabling rows for editing by clicking the buttons above the table. The requests made when deltaSubmit=true are correct, and they contain the new values entered when editing, but in the decoding phase the submitted value (retrieved from the request parameters map, using the component's client id as a key) is always the previous value, and not what was edited in the text field and sent in the request. This also occurs with other input components. It seems like the internal mechanism used by delta submit to compare previous values is reverting the values sent in the request, under certain scenarios.
        Ken Fyten made changes -
        Summary showcase dataTable Row State and Row/Cell Editing fail when DeltaSubmit=true showcase ace:dataTable Row State and Row/Cell Editing fail when DeltaSubmit=true
        Arturo Zambrano made changes -
        Fix Version/s 4.1 [ 11375 ]
        Hide
        Arturo Zambrano added a comment -

        Added 4.1 target, since this issue is also reproducible on the 4.x trunk.

        Show
        Arturo Zambrano added a comment - Added 4.1 target, since this issue is also reproducible on the 4.x trunk.
        Hide
        Arturo Zambrano added a comment -

        The problem seems to be that the parameters with the remove prefix ('patch-') are not being included in the delta submit request for any input fields inside cell editors, unlike other input fields that are always visible. When I artificially added the corresponding 'patch-' parameter for a specific field that was edited, the new value was saved successfully and the table cell displayed the value just entered, instead of reverting to the original value.

        Show
        Arturo Zambrano added a comment - The problem seems to be that the parameters with the remove prefix ('patch-') are not being included in the delta submit request for any input fields inside cell editors, unlike other input fields that are always visible. When I artificially added the corresponding 'patch-' parameter for a specific field that was edited, the new value was saved successfully and the table cell displayed the value just entered, instead of reverting to the original value.
        Hide
        Arturo Zambrano added a comment -

        Committed fix to the 3.3 EE maintenance branch at revision 44702 and to the P03 tag at revision 44701. The fix consists in adding 'patch-' parameters to the request, corresponding to input fields inside cell editors whose value changed, when deltaSubmit=true.

        Show
        Arturo Zambrano added a comment - Committed fix to the 3.3 EE maintenance branch at revision 44702 and to the P03 tag at revision 44701. The fix consists in adding 'patch-' parameters to the request, corresponding to input fields inside cell editors whose value changed, when deltaSubmit=true.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44703 Mon May 18 19:00:38 MDT 2015 art.zambrano ICE-10670 fix to add 'patch-' parameters to the request, corresponding to input fields inside cell editors whose value changed, when deltaSubmit=true
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Hide
        Arturo Zambrano added a comment -

        Committed fix to the 4.x trunk at revision 44703.

        Show
        Arturo Zambrano added a comment - Committed fix to the 4.x trunk at revision 44703.
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces EE-3.3.0.GA_P03 tag, EE-maintenance branch r44706, Tomcat 7, IE 11, 10, 9, 8, 7, Chrome 42, FF 34.

        When tested with ICEfaces 4 trunk the new data could not be submitted and a console error appears. This is an issue whether deltaSubmit is set to true or false.
        ReferenceError: changes is not defined
        http://localhost:8080/showcase/javax.faces.resource/bridge.js.jsf?ln=ice.core&v=4_1_0_150519 line 2 > eval
        Line 139

        Show
        Liana Munroe added a comment - Verified ICEfaces EE-3.3.0.GA_P03 tag, EE-maintenance branch r44706, Tomcat 7, IE 11, 10, 9, 8, 7, Chrome 42, FF 34. When tested with ICEfaces 4 trunk the new data could not be submitted and a console error appears. This is an issue whether deltaSubmit is set to true or false. ReferenceError: changes is not defined http://localhost:8080/showcase/javax.faces.resource/bridge.js.jsf?ln=ice.core&v=4_1_0_150519 line 2 > eval Line 139
        Liana Munroe made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44707 Tue May 19 11:02:38 MDT 2015 art.zambrano ICE-10670 corrected previous fix
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Hide
        Arturo Zambrano added a comment -

        r44707: made a correction to the fix on the 4.x trunk.

        Show
        Arturo Zambrano added a comment - r44707: made a correction to the fix on the 4.x trunk.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r44708, Tomcat 7, IE 11, FF 34, Chrome 42.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r44708, Tomcat 7, IE 11, FF 34, Chrome 42.
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces EE-3.3.0.GA_P03 Jenkins build 08, Tomcat 7, IE 11, 10, 9, 8, 7, Chrome 42, FF 34

        Show
        Liana Munroe added a comment - Verified ICEfaces EE-3.3.0.GA_P03 Jenkins build 08, Tomcat 7, IE 11, 10, 9, 8, 7, Chrome 42, FF 34
        Ken Fyten made changes -
        Affects Version/s EE-3.3.0.GA_P01 [ 11174 ]
        Affects Version/s EE-3.3.0.GA_P03 [ 11572 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Liana Munroe
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: