ICEfaces
  1. ICEfaces
  2. ICE-10644

ace:contextMenu inside ice:dataTable fails to update more than first row.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P02
    • Fix Version/s: EE-3.3.0.GA_P03
    • Labels:
      None
    • Environment:
      ICEfaces EE-3.3.0 maintenance branch r44519. Tomcat 7, all browsers.
      Note that this was last known to be working with EE-3.3.0_p01 libs.
    • Assignee Priority:
      P1

      Description

      Manual testing of contextMenu inside ice:dataTable found that text is not rendered on page when opening component from second and third row.

      To reproduce:
      1.) Use /contextMenuIceTable.jsf located at
      C:\svn\repo\qa\trunk\Regression-Icefaces2\Sparkle\Nightly\contextMenu
      2.) Right click on image in first row of table. Context menu displays and a menu option can be selected and displayed as a selected value.
      3.) Right click on image in 2nd or 3rd row of table.Context menu displays and a menu option can be selected, but will not be displayed as a selected value.

        Issue Links

          Activity

          Liana Munroe created issue -
          Liana Munroe made changes -
          Field Original Value New Value
          Summary ace:contextMenu inside ice:dataTable fails to render more than first row ace:contextMenu inside ice:dataTable fails to update more than first row.
          Ken Fyten made changes -
          Assignee Arturo Zambrano [ artzambrano ]
          Fix Version/s EE-3.3.0.GA_P03 [ 11572 ]
          Environment ICEfaces EE-3.3.0 maintenance branch r44519. Tomcat 7, all browsers. Is not an issue when tested with EE-3.3.0_p01 libs. ICEfaces EE-3.3.0 maintenance branch r44519. Tomcat 7, all browsers.
          Note that this was last known to be working with EE-3.3.0_p01 libs.
          Assignee Priority P2 [ 10011 ]
          Hide
          Arturo Zambrano added a comment -

          r44535: Committed fix to the 3.3 EE maintenance branch. In UISeriesBase.java, removed setRowIndex() call from section that iterates over child components in visitRows(), since the row index is set previously in that method, and there's no need to alter the row index when visiting children (i.e. horizontally).

          Testing notes: For now just test the basic case described here. This fix will require some regression testing, since it affects various components that extend from UISeriesBase (ice.dataTable, ice:panelSeries, ice:panelTabSet, ice:panelPositioned, and ace:list), as well as ICE-9707 and ICE-3136. Please wait until this fix is reviewed before proceeding with the regression tests.

          Show
          Arturo Zambrano added a comment - r44535: Committed fix to the 3.3 EE maintenance branch. In UISeriesBase.java, removed setRowIndex() call from section that iterates over child components in visitRows(), since the row index is set previously in that method, and there's no need to alter the row index when visiting children (i.e. horizontally). Testing notes: For now just test the basic case described here. This fix will require some regression testing, since it affects various components that extend from UISeriesBase (ice.dataTable, ice:panelSeries, ice:panelTabSet, ice:panelPositioned, and ace:list), as well as ICE-9707 and ICE-3136 . Please wait until this fix is reviewed before proceeding with the regression tests.
          Arturo Zambrano made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Assignee Arturo Zambrano [ artzambrano ] Mircea Toma [ mircea.toma ]
          Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
          Hide
          Liana Munroe added a comment -

          Tested with ICEfaces EE-3.3.0 maintenance branch r44538. Issue as described is verified fixed. Tomcat 7, IE 11, FF 34, Chrome 41.

          Show
          Liana Munroe added a comment - Tested with ICEfaces EE-3.3.0 maintenance branch r44538. Issue as described is verified fixed. Tomcat 7, IE 11, FF 34, Chrome 41.
          Hide
          Mircea Toma added a comment - - edited

          Art's fix looks good to me. As he noted, we should have regression testing done since UISeriesBase it's quite a change sensitive class.

          Need to test all components that support iteration and also with partialStateSaving=false.

          Show
          Mircea Toma added a comment - - edited Art's fix looks good to me. As he noted, we should have regression testing done since UISeriesBase it's quite a change sensitive class. Need to test all components that support iteration and also with partialStateSaving=false.
          Mircea Toma made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Judy Guglielmin made changes -
          Link This issue blocks MOBI-1134 [ MOBI-1134 ]
          Carmen Cristurean made changes -
          Component/s ICE-Components [ 10012 ]
          Hide
          Ken Fyten added a comment -

          Re-opened due to regression captured in ICE-10664.

          Show
          Ken Fyten added a comment - Re-opened due to regression captured in ICE-10664.
          Ken Fyten made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Mircea Toma added a comment -

          Set row index when iterating over children to save their new state (in case components have relocated). This is done without row index reset.

          Show
          Mircea Toma added a comment - Set row index when iterating over children to save their new state (in case components have relocated). This is done without row index reset.
          Mircea Toma made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Liana Munroe added a comment -

          Verified ICEfaces EE-3.3.0. GA_P03 tag and maintenance branch r44718. Tomcat 7, IE 11, FF 34, Chrome 42.

          Show
          Liana Munroe added a comment - Verified ICEfaces EE-3.3.0. GA_P03 tag and maintenance branch r44718. Tomcat 7, IE 11, FF 34, Chrome 42.
          Hide
          Liana Munroe added a comment -

          Verified ICEfaces EE-3.3.0. GA_P03 Jenkins Build 08. Tomcat 7, IE 11, 10, 9, 8, 7, FF 34, Chrome 42

          Show
          Liana Munroe added a comment - Verified ICEfaces EE-3.3.0. GA_P03 Jenkins Build 08. Tomcat 7, IE 11, 10, 9, 8, 7, FF 34, Chrome 42
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Mircea Toma
              Reporter:
              Liana Munroe
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: