Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: EE-3.3.0.GA_P02
-
Fix Version/s: EE-3.3.0.GA_P03
-
Component/s: ACE-Components, ICE-Components
-
Labels:None
-
Environment:ICEfaces EE-3.3.0 maintenance branch r44519. Tomcat 7, all browsers.
Note that this was last known to be working with EE-3.3.0_p01 libs.
-
Assignee Priority:P1
Description
To reproduce:
1.) Use /contextMenuIceTable.jsf located at
C:\svn\repo\qa\trunk\Regression-Icefaces2\Sparkle\Nightly\contextMenu
2.) Right click on image in first row of table. Context menu displays and a menu option can be selected and displayed as a selected value.
3.) Right click on image in 2nd or 3rd row of table.Context menu displays and a menu option can be selected, but will not be displayed as a selected value.
Issue Links
- blocks
-
MOBI-1134
update ace-generator.jar for icemobile project
-
- Resolved
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Summary | ace:contextMenu inside ice:dataTable fails to render more than first row | ace:contextMenu inside ice:dataTable fails to update more than first row. |
| Assignee | Arturo Zambrano [ artzambrano ] | |
| Fix Version/s | EE-3.3.0.GA_P03 [ 11572 ] | |
| Environment | ICEfaces EE-3.3.0 maintenance branch r44519. Tomcat 7, all browsers. Is not an issue when tested with EE-3.3.0_p01 libs. |
ICEfaces EE-3.3.0 maintenance branch r44519. Tomcat 7, all browsers.
Note that this was last known to be working with EE-3.3.0_p01 libs. |
| Assignee Priority | P2 [ 10011 ] |
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
| Assignee | Arturo Zambrano [ artzambrano ] | Mircea Toma [ mircea.toma ] |
| Assignee Priority | P2 [ 10011 ] | P1 [ 10010 ] |
Tested with ICEfaces EE-3.3.0 maintenance branch r44538. Issue as described is verified fixed. Tomcat 7, IE 11, FF 34, Chrome 41.
Art's fix looks good to me. As he noted, we should have regression testing done since UISeriesBase it's quite a change sensitive class.
Need to test all components that support iteration and also with partialStateSaving=false.
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Component/s | ICE-Components [ 10012 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
Set row index when iterating over children to save their new state (in case components have relocated). This is done without row index reset.
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
Verified ICEfaces EE-3.3.0. GA_P03 tag and maintenance branch r44718. Tomcat 7, IE 11, FF 34, Chrome 42.
Verified ICEfaces EE-3.3.0. GA_P03 Jenkins Build 08. Tomcat 7, IE 11, 10, 9, 8, 7, FF 34, Chrome 42
| Status | Resolved [ 5 ] | Closed [ 6 ] |
r44535: Committed fix to the 3.3 EE maintenance branch. In UISeriesBase.java, removed setRowIndex() call from section that iterates over child components in visitRows(), since the row index is set previously in that method, and there's no need to alter the row index when visiting children (i.e. horizontally).
Testing notes: For now just test the basic case described here. This fix will require some regression testing, since it affects various components that extend from UISeriesBase (ice.dataTable, ice:panelSeries, ice:panelTabSet, ice:panelPositioned, and ace:list), as well as ICE-9707 and
ICE-3136. Please wait until this fix is reviewed before proceeding with the regression tests.