ICEfaces
  1. ICEfaces
  2. ICE-10617

ace:tableConfigPanel attribute "hideDisabledRows" doesn't work

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces trunk, Tomcat
    • Assignee Priority:
      P3

      Description

      Example:

      <ace:tableConfigPanel columnNameConfigurable="false"
                            columnOrderingConfigurable="true"
                            columnSortingConfigurable="false"
                            columnVisibilityConfigurable="true"
                            type="last-col" hideDisabledRows="true"
                            modal="true"/>

      When rendered on the page, the sort order and name columns are still disabled (instead of un-rendered) even though hideDisabledRows="true"

      Which means these two columns:
        columnNameConfigurable="false"
        columnSortingConfigurable="false"
      shouldn't be rendered.

        Activity

        Carlo Guglielmin created issue -
        Carlo Guglielmin made changes -
        Field Original Value New Value
        Description Example:

        <ace:tableConfigPanel columnNameConfigurable="false"
                              columnOrderingConfigurable="true"
                              columnSortingConfigurable="false"
                              columnVisibilityConfigurable="true"
                              type="last-col" hideDisabledRows="true"
                              modal="true"/>

        When rendered on the page, the sort order and name columns are still disabled (instead of un-rendered) even though hideDisabledRows="true"

        Which means these two columns:
        columnNameConfigurable="false"
        columnSortingConfigurable="false"

        Shouldn't be rendered.
        Example:

        <ace:tableConfigPanel columnNameConfigurable="false"
                              columnOrderingConfigurable="true"
                              columnSortingConfigurable="false"
                              columnVisibilityConfigurable="true"
                              type="last-col" hideDisabledRows="true"
                              modal="true"/>

        When rendered on the page, the sort order and name columns are still disabled (instead of un-rendered) even though hideDisabledRows="true"

        Which means these two columns:
          columnNameConfigurable="false"
          columnSortingConfigurable="false"
        shouldn't be rendered.
        Hide
        Carlo Guglielmin added a comment -

        Added a screenshot example that uses hideDisabledRows, but as you can see the columns in the tableConfigPanel are still rendered and disabled instead of hidden/un-rendered.

        Show
        Carlo Guglielmin added a comment - Added a screenshot example that uses hideDisabledRows, but as you can see the columns in the tableConfigPanel are still rendered and disabled instead of hidden/un-rendered.
        Carlo Guglielmin made changes -
        Attachment disabled-vs-rendered.png [ 19080 ]
        Ken Fyten made changes -
        Assignee Arturo Zambrano [ artzambrano ]
        Fix Version/s 4.1 [ 11375 ]
        Assignee Priority P3 [ 10012 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45764 Thu Jul 16 14:41:54 MDT 2015 art.zambrano ICE-10617 added selectAllRows, deselectAllRows, selectAllCells and deselectAllCells client-side utility functions for ace:dataTable
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Arturo Zambrano made changes -
        Attachment hideDisabledRows.png [ 20486 ]
        Arturo Zambrano made changes -
        Attachment hideDisabledRows-true.png [ 20487 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45767 Thu Jul 16 18:13:38 MDT 2015 art.zambrano ICE-10617 clarified description for 'hideDisabledRows' attribute
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tableconfigpanel/TableConfigPanelMeta.java
        Hide
        Arturo Zambrano added a comment -

        r45767: clarified description for 'hideDisabledRows' attribute

        Marking as invalid, as the 'hideDisabledRows' is working correctly. It is actually applied when ace:column components have their 'configurable' attribute set to false. It is not applied to the configuration columns in the table configuration panel. As can be seen in the attached screenshots, when columns have configurable="false", they are rendered with a disabled styling, and when ace:tableConfigPanel has hideDisabledRows="true", these columns aren't rendered in the panel at all. The attribute description wasn't clear enough, and that has now been corrected.

        Show
        Arturo Zambrano added a comment - r45767: clarified description for 'hideDisabledRows' attribute Marking as invalid, as the 'hideDisabledRows' is working correctly. It is actually applied when ace:column components have their 'configurable' attribute set to false. It is not applied to the configuration columns in the table configuration panel. As can be seen in the attached screenshots, when columns have configurable="false", they are rendered with a disabled styling, and when ace:tableConfigPanel has hideDisabledRows="true", these columns aren't rendered in the panel at all. The attribute description wasn't clear enough, and that has now been corrected.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Invalid [ 6 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Carlo Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: