Details
-
Type: Bug
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 4.0
-
Fix Version/s: EE-4.0.0.GA, 4.1
-
Component/s: ICECORE-Components
-
Labels:None
-
Environment:jsf 2.2 icecore
-
Assignee Priority:P1
-
Workaround Description:if element is always visible in the app, this will not be a problem (not always feasible).
Description
writer.startElement("script", null);
writer.writeText("ice.onUserInactivity(", null);
writer.writeText(getInterval(), null);
writer.writeText(", function() { document.getElementById('", null);
writer.writeText(containerID, null);
writer.writeText("').style.visibility = 'visible'; }", null);
writer.writeText(", function() { document.getElementById('", null);
writer.writeText(containerID, null);
writer.writeText("').style.visibility = 'hidden'; });", null);
writer.endElement("script");
should be modified so that null check is done before applying style.
In showcase app, if you select icecore:idleMonitor and then go to another example page, this component is still active and trying to change the style. Ideally, this is something visible on template throughout the entire application, but can foresee some instances (currently exhibited in showcase even if this was in the header for example so always visible, would still not be available in mobile showcase...)
So null check should be done.
writer.writeText("ice.onUserInactivity(", null);
writer.writeText(getInterval(), null);
writer.writeText(", function() { document.getElementById('", null);
writer.writeText(containerID, null);
writer.writeText("').style.visibility = 'visible'; }", null);
writer.writeText(", function() { document.getElementById('", null);
writer.writeText(containerID, null);
writer.writeText("').style.visibility = 'hidden'; });", null);
writer.endElement("script");
should be modified so that null check is done before applying style.
In showcase app, if you select icecore:idleMonitor and then go to another example page, this component is still active and trying to change the style. Ideally, this is something visible on template throughout the entire application, but can foresee some instances (currently exhibited in showcase even if this was in the header for example so always visible, would still not be available in mobile showcase...)
So null check should be done.
Activity
Judy Guglielmin
created issue -
Judy Guglielmin
made changes -
Field | Original Value | New Value |
---|---|---|
Fix Version/s | EE-4.0.0.GA [ 11171 ] |
Ken Fyten
made changes -
Assignee | Arturo Zambrano [ artzambrano ] | |
Assignee Priority | P1 [ 10010 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #44321 | Fri Mar 27 12:56:18 MDT 2015 | art.zambrano | |
Files Changed | ||||
MODIFY
/icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/impl/component/IdleMonitor.java
|
Arturo Zambrano
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Security | Private [ 10001 ] |
Ken Fyten
made changes -
Fix Version/s | 4.1 [ 11375 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
r444321: added null checks to icecore:idleMonitor container before applying style.
r44322: committed fix to tag.