ICEfaces
  1. ICEfaces
  2. ICE-10577

ace:dataTable - Issues with filterEvent="enter"

          Details

            Description

            Issue #1: When using filterEvent="enter" filtering should only happen on the enter key press. This is working fine when typing in filter input but when removing text via the backspace key, a filter event is fired for each back space key press.

            Issue #2: When using multiple filter fields, only the field that has the enter key pressed on will do the filtering, the other field is cleared. To test with attach test case:
             - Enter in 'a' in the first column.
             - Enter in '1' in the second column.
             - Click enter, the first column field is cleared and filtering happens for just the second column.

            Issue #3: The enter filter event isn't working on the ICEfaces 4 and ICEfaces EE 3 trunk code. It is clearing out the field and not doing any filtering.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case that shows the issue.

              Steps:

              • Load welcomeICEfaces.jsf
              • Enter in some text into a filter input field.
              • Press the enter key, filtered data is shown.
              • Use the backspace key to delete text, another filter event is called.
              Show
              Arran Mccullough added a comment - Attached test case that shows the issue. Steps: Load welcomeICEfaces.jsf Enter in some text into a filter input field. Press the enter key, filtered data is shown. Use the backspace key to delete text, another filter event is called.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed fix to the 4.0 trunk at revision 44314, to the 4.0 EE tag at revision 44315, and to the 3.3 EE maintenance branch at revision 44316.

              The fix consists in adding submitOnEnter=disabled to the filter fields, in order to prevent the bridge from handling the filtering request, instead of the table. This solves issues #1 and #3 above. Also, modified the FilterState class to save the filter values of all columns in the table, not just the one that submitted the filtering request. This solves issue #2.

              Show
              Arturo Zambrano added a comment - Committed fix to the 4.0 trunk at revision 44314, to the 4.0 EE tag at revision 44315, and to the 3.3 EE maintenance branch at revision 44316. The fix consists in adding submitOnEnter=disabled to the filter fields, in order to prevent the bridge from handling the filtering request, instead of the table. This solves issues #1 and #3 above. Also, modified the FilterState class to save the filter values of all columns in the table, not just the one that submitted the filtering request. This solves issue #2.
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified fixes with the attached test case on EE-4.0 Jenkins Build#3 in IE11, FF34, Chrome41.

              Show
              Carmen Cristurean added a comment - Verified fixes with the attached test case on EE-4.0 Jenkins Build#3 in IE11, FF34, Chrome41.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Fixed Javascript errors above in the 3.3 EE maintenance branch at revision 44347.

              Show
              Arturo Zambrano added a comment - Fixed Javascript errors above in the 3.3 EE maintenance branch at revision 44347.

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: