ICEfaces
  1. ICEfaces
  2. ICE-10576

ace:gMapAutocomplete - Selecting a specific location gets reverted to Canada

    Details

      Description

      This issue can be reproduced with the Showcase ace:gMapAutocomplete demo.

      Steps:
       - Enter "Vallières" in the Location field.
       - From the suggested addresses list, select "Vallières / Saint-Martin [46057], Laval, QC".
       - The Location field value immediately becomes "Canada".

        Activity

        Arran Mccullough created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee Arturo Zambrano [ artzambrano ]
        Fix Version/s EE-4.0.0.GA [ 11171 ]
        Fix Version/s EE-3.3.0.GA_P03 [ 11572 ]
        Priority Major [ 3 ] Minor [ 4 ]
        Assignee Priority P2 [ 10011 ]
        Hide
        Arturo Zambrano added a comment -

        This seems to be an issue with the Google Maps data for this specific location. Our code works normally for this result as for other results that don't present this issue. The code path is the same. The problem occurs in the event listener that we register for the 'place_changed' event in the autocomplete functionality of Google Maps. The 'place' object received in the event listener simply contains 'Canada' in its 'formatted_address' property, instead of the full location that was selected.

        Show
        Arturo Zambrano added a comment - This seems to be an issue with the Google Maps data for this specific location. Our code works normally for this result as for other results that don't present this issue. The code path is the same. The problem occurs in the event listener that we register for the 'place_changed' event in the autocomplete functionality of Google Maps. The 'place' object received in the event listener simply contains 'Canada' in its 'formatted_address' property, instead of the full location that was selected.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44318 Thu Mar 26 18:15:40 MDT 2015 art.zambrano ICE-10576 fix to check for special characters in the autocomplete input field, and in such case, process location via Geocoding, instead of using the data passed to the event handler function, which is inaccurate in those cases
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/gmap/gmap.js
        Hide
        Arturo Zambrano added a comment -

        Committed fix to the 4.0 trunk at revision 44318, to 4.0 EE tag at revision 44319, and to the 3.3 EE maintenance branch at revision 44320.

        The fix consists in checking for special characters in the autocomplete input field, and in such case, process location via Geocoding, instead of using the data passed to the event handler function, which is inaccurate in those cases.

        Show
        Arturo Zambrano added a comment - Committed fix to the 4.0 trunk at revision 44318, to 4.0 EE tag at revision 44319, and to the 3.3 EE maintenance branch at revision 44320. The fix consists in checking for special characters in the autocomplete input field, and in such case, process location via Geocoding, instead of using the data passed to the event handler function, which is inaccurate in those cases.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces EE-4.0.0 Jenkins build 3, ICEfaces ee-3.3.0 maintenance branch r44342 using showcase gMap > Autocomplete demo as well as QA test app for GMap AutoComplete. Tomcat 7, IE 11, FF 34, Chrome 41.

        Show
        Liana Munroe added a comment - Verified ICEfaces EE-4.0.0 Jenkins build 3, ICEfaces ee-3.3.0 maintenance branch r44342 using showcase gMap > Autocomplete demo as well as QA test app for GMap AutoComplete. Tomcat 7, IE 11, FF 34, Chrome 41.
        Ken Fyten made changes -
        Fix Version/s 4.1 [ 11375 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: