ICEfaces
  1. ICEfaces
  2. ICE-10563

ice:inputText - Vaue Change Event fired when typing an umlaut in Firefox

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P02
          • Fix Version/s: EE-3.3.0.GA_P03
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Firefox, German Keyboard layout

            Description

            When typing in an umlaut (öäü) in the ice:inputText, it is causing the valueChangeEvent to be fired. This is with both partialSubmit set to false and true. This also only happens in Firefox.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case that shows this issue. Note, the icefaces, ace, and compat jars need to be added into the war file to run.

              Steps:

              • Load welcomeICEfaces.jsf
              • Type in an umlaut (üöä) into the input field. On keypress the value change event is fired.
              Show
              Arran Mccullough added a comment - Attached test case that shows this issue. Note, the icefaces, ace, and compat jars need to be added into the war file to run. Steps: Load welcomeICEfaces.jsf Type in an umlaut (üöä) into the input field. On keypress the value change event is fired.
              Hide
              Permalink
              Mircea Toma added a comment -

              I cannot reproduce this issue. I tried with FF on OSX and Window 7. I also made sure to change the keyboard to German.

              Show
              Mircea Toma added a comment - I cannot reproduce this issue. I tried with FF on OSX and Window 7. I also made sure to change the keyboard to German.
              Hide
              Permalink
              Arran Mccullough added a comment -

              I can still reproduce this with the current EE 3.3.0 branch code. What version of Firefox were you using? I'm testing with 36.0.4.

              I also installed a new Language via the Windows control panel-> Languages. Then on the taskbar I could change the keyboard to the German layout.

              Show
              Arran Mccullough added a comment - I can still reproduce this with the current EE 3.3.0 branch code. What version of Firefox were you using? I'm testing with 36.0.4. I also installed a new Language via the Windows control panel-> Languages. Then on the taskbar I could change the keyboard to the German layout.
              Hide
              Permalink
              Mircea Toma added a comment -

              This issue occurs because of the simplistic strategy used by the iceSubmit to detect key triggered DOM events. The function assumes that events with key code property value greater than 3 are key events. In the case of umlaut, FF will return 0 for the key code causing the function to issue the submit (not desired for key events).

              Show
              Mircea Toma added a comment - This issue occurs because of the simplistic strategy used by the iceSubmit to detect key triggered DOM events. The function assumes that events with key code property value greater than 3 are key events. In the case of umlaut , FF will return 0 for the key code causing the function to issue the submit (not desired for key events).
              Hide
              Permalink
              Mircea Toma added a comment -

              Introduced isKeyEvent function that detects key triggered events by looking at the event type. Modified iceSubmit to use this new function.

              Show
              Mircea Toma added a comment - Introduced isKeyEvent function that detects key triggered events by looking at the event type. Modified iceSubmit to use this new function.
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces EE-3.3.0 maintenance branch r44413 using attached test case, Tomcat 7, FF 34 and FF 36.

              Show
              Liana Munroe added a comment - Verified ICEfaces EE-3.3.0 maintenance branch r44413 using attached test case, Tomcat 7, FF 34 and FF 36.

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: