ICEfaces
  1. ICEfaces
  2. ICE-10529

ace:dataTable - filter focus lost on update

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P02, 4.0
    • Fix Version/s: EE-4.0.0.GA, EE-3.3.0.GA_P03, 4.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Firefox, Chrome, IE11

      Description

      In a filter enabled ace:dataTable, the focus is lost when deleting characters from the filter input field. Upon loss of focus, using the backspace yet will return the user to the previous page.

      This happens with the 'change' and 'keyup' filter events. When deleting characters in the field, if there new data to be shown, the focus is lost.

        Activity

        Hide
        Arturo Zambrano added a comment -

        r44268: committed fix to 3.3 EE maintenance branch.

        Show
        Arturo Zambrano added a comment - r44268: committed fix to 3.3 EE maintenance branch.
        Hide
        Liana Munroe added a comment -

        ICEfaces 4 trunk r 44269, EE-4.0.0 r41228.
        Just started the regression testing for the latest fix and immediately found an issue when using a filter and backspacing the input:
        Console error all browsers:
        ReferenceError: _self is not defined
        http://localhost:8080/showcase/javax.faces.resource/bridge.js.jsf?ln=ice.core&v=4_0_0_150319 line 2 > eval
        Line 16

        This can be reproduced by using the showcase ace:dataTable > Overview demo.
        1.) Type the letters End into the input in the Name header .
        2.) Table will be filtered, press backspace to remove all input.
        3.) Error appears in browser console.

        Show
        Liana Munroe added a comment - ICEfaces 4 trunk r 44269, EE-4.0.0 r41228. Just started the regression testing for the latest fix and immediately found an issue when using a filter and backspacing the input: Console error all browsers: ReferenceError: _self is not defined http://localhost:8080/showcase/javax.faces.resource/bridge.js.jsf?ln=ice.core&v=4_0_0_150319 line 2 > eval Line 16 This can be reproduced by using the showcase ace:dataTable > Overview demo. 1.) Type the letters End into the input in the Name header . 2.) Table will be filtered, press backspace to remove all input. 3.) Error appears in browser console.
        Hide
        Arturo Zambrano added a comment -

        r44273: added global cache for the filter event listener, which needs to be global and static.

        The issue was caused because of an event listener function that was made static, but it still had a reference to the data table object. This was fixed by having a global cache to store these event listener functions, which are created for each data table instance with a reference to it.

        Show
        Arturo Zambrano added a comment - r44273: added global cache for the filter event listener, which needs to be global and static. The issue was caused because of an event listener function that was made static, but it still had a reference to the data table object. This was fixed by having a global cache to store these event listener functions, which are created for each data table instance with a reference to it.
        Hide
        Arturo Zambrano added a comment -

        r44274: committed last fix to 3.3 EE maintenance branch.

        Show
        Arturo Zambrano added a comment - r44274: committed last fix to 3.3 EE maintenance branch.
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r44806. Tomcat 7, FF 34, IE 11 Chrome 43.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r44806. Tomcat 7, FF 34, IE 11 Chrome 43.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: