Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: EE-3.3.0.GA_P02, 4.0
-
Fix Version/s: EE-4.0.0.GA, EE-3.3.0.GA_P03, 4.1
-
Component/s: Framework
-
Labels:None
-
Environment:jsf 2 icefaces
-
Assignee Priority:P1
-
Support Case References:Support Case 13323:- https://icesoft.my.salesforce.com/50070000013VsPa
Description
See attached sample app to reproduce. I have tested it with 3.3.0 open source (easier to build as it's maven-built) as well as 3.3.0.GA_P02.
The sample app basically has a page with 2 links.
<h:form id="frm">
<h:commandLink value="Add component to tree"
actionListener="#{requestBean.addComponent}"/>
<br/>
<h:commandLink value="Trigger lifecycle"
actionListener="#{requestBean.doNothing}"/>
<br/>
<h:panelGroup id="pgrp" binding="#{requestBean.group}">
</h:panelGroup>
</h:form>
One link will dynamically add an HtmlOutputText component to an HtmlPanelGroup. the other link just triggers a jsf lifecycle.
If you remove the icefaces jar from the war, with PartialStateSaving set to true (default anyways), then the HtmlPanelGroup state will continue to add another HtmlOutputText when you click on a link. With the icefaces jar, you only ever get the last HtmlOutputText component and if you trigger a new jsf lifecycle, it clears all state of the HtmlPanelGroup.
The only way to maintain state with the icefaces jar is to set PartialStateSaving to false in web.xml:-
<param-name>javax.faces.PARTIAL_STATE_SAVING</param-name>
<param-value>false</param-value>
and this is inconsistent with how JSF is behaving.
Customer has suggested a fix. (see diff attached).
The sample app basically has a page with 2 links.
<h:form id="frm">
<h:commandLink value="Add component to tree"
actionListener="#{requestBean.addComponent}"/>
<br/>
<h:commandLink value="Trigger lifecycle"
actionListener="#{requestBean.doNothing}"/>
<br/>
<h:panelGroup id="pgrp" binding="#{requestBean.group}">
</h:panelGroup>
</h:form>
One link will dynamically add an HtmlOutputText component to an HtmlPanelGroup. the other link just triggers a jsf lifecycle.
If you remove the icefaces jar from the war, with PartialStateSaving set to true (default anyways), then the HtmlPanelGroup state will continue to add another HtmlOutputText when you click on a link. With the icefaces jar, you only ever get the last HtmlOutputText component and if you trigger a new jsf lifecycle, it clears all state of the HtmlPanelGroup.
The only way to maintain state with the icefaces jar is to set PartialStateSaving to false in web.xml:-
<param-name>javax.faces.PARTIAL_STATE_SAVING</param-name>
<param-value>false</param-value>
and this is inconsistent with how JSF is behaving.
Customer has suggested a fix. (see diff attached).
Activity
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Fix Version/s | 4.1 [ 11375 ] |
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Assignee | Judy Guglielmin [ judy.guglielmin ] | Mircea Toma [ mircea.toma ] |
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
| Assignee | Ken Fyten [ ken.fyten ] | Judy Guglielmin [ judy.guglielmin ] |
| Assignee | Judy Guglielmin [ judy.guglielmin ] | Ken Fyten [ ken.fyten ] |
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Assignee | Mircea Toma [ mircea.toma ] | Judy Guglielmin [ judy.guglielmin ] |
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #44261 | Wed Mar 18 14:47:07 MDT 2015 | mircea.toma | |
| Files Changed | ||||
MODIFY
/icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java
|
| Affects Version/s | 4.0 [ 11382 ] |
| Fix Version/s | EE-4.0.0.GA [ 11171 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Attachment | sc13323a.war [ 18580 ] |
| Assignee | Ken Fyten [ ken.fyten ] | Mircea Toma [ mircea.toma ] |
| Assignee Priority | P1 [ 10010 ] |
| Fix Version/s | EE-3.3.0.GA_P03 [ 11572 ] |
| Attachment | state_saving.patch [ 18497 ] | |
| Attachment | state_saving.zip [ 18498 ] |
| Attachment | ice3sbx.war [ 18496 ] |
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Ken Fyten [ ken.fyten ] |

Verified on ICEfaces4 trunk r.44504 (test case "ice3sbx"), and ICEfaces 3.3.0 r.44504 (test cases "ice3sbx" and "sc13323a"), in IE11, Chrome41, FF34.
Regression tests added to the QA framework:
http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/ICE-10524
http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Manual/ICE-10524
http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Manual/ICE-10524a