ICEfaces
  1. ICEfaces
  2. ICE-10515

JQMIGRATE warning "jQuery.browser is deprecated"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: EE-4.0.0.GA, 4.1
    • Component/s: ACE-Components, QA
    • Labels:
      None
    • Environment:
      ICEfaces4 trunk r44109
      Browsers: all
      Server: Tomcat7.0.42
    • Assignee Priority:
      P2

      Description

      A warning is seen in browser console when accessing test pages for certain ACE components, or when enabling ACE components to render on the test page; as example:
      - ace:selectMenu inside ace:tabSet;
      - ace:selectMenu Dynamic Attribute test;
      - ace:comboBox > Attribute test.
      - ace:comboBox > Dynamic Attribute Test

      IE11/FF34/Chrome40 warning message:
      JQMIGRATE: jQuery.browser is deprecated

      QA test apps:
      http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/selectMenu
      Test pages:
      /selectMenuAceTabSet.jsf
      /selectMenuDynAttribute.jsf

      http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/comboBox
      Test pages:
      /comboBoxAttribute.jsf
      /comboBoxDynAttribute.jsf


      This warning does not appear to affect tests functionality.

        Activity

        Hide
        Ken Fyten added a comment -

        According to the jQuery-migrate page (https://github.com/jquery/jquery-migrate/blob/master/warnings.md), this warning is being generated because we are using the uncompressed development version of jquery, and we are using a deprecated API.

        JQMIGRATE: jQuery.browser is deprecated

        Cause: jQuery.browser was deprecated in version 1.3, and finally removed in 1.9. Browser sniffing is notoriously unreliable as means of detecting whether to implement particular features.

        Solution: Where possible, use feature detection to make code decisions rather than trying to detect a specific browser. The Modernizr library provides a wide variety of feature detections. As a last resort, you can directly look at the navigator.userAgent string to detect specific strings returned by the browser.

        Show
        Ken Fyten added a comment - According to the jQuery-migrate page ( https://github.com/jquery/jquery-migrate/blob/master/warnings.md ), this warning is being generated because we are using the uncompressed development version of jquery, and we are using a deprecated API. JQMIGRATE: jQuery.browser is deprecated Cause: jQuery.browser was deprecated in version 1.3, and finally removed in 1.9. Browser sniffing is notoriously unreliable as means of detecting whether to implement particular features. Solution: Where possible, use feature detection to make code decisions rather than trying to detect a specific browser. The Modernizr library provides a wide variety of feature detections. As a last resort, you can directly look at the navigator.userAgent string to detect specific strings returned by the browser.
        Hide
        Arturo Zambrano added a comment -

        r44118: commented out JQMIGRATE jQuery.browser deprecated message from jquery.js.

        Show
        Arturo Zambrano added a comment - r44118: commented out JQMIGRATE jQuery.browser deprecated message from jquery.js.
        Hide
        Arturo Zambrano added a comment -

        Created ICE-10520 to implement an improved browser detection strategy.

        Show
        Arturo Zambrano added a comment - Created ICE-10520 to implement an improved browser detection strategy.
        Hide
        Ken Fyten added a comment -

        Re-opened to apply to the 3.3 maintenance branch as well.

        Show
        Ken Fyten added a comment - Re-opened to apply to the 3.3 maintenance branch as well.
        Hide
        Arturo Zambrano added a comment -

        Closing again and removing 3.3 target. This message is actually not shown when using the ICEfaces 3.3.

        Show
        Arturo Zambrano added a comment - Closing again and removing 3.3 target. This message is actually not shown when using the ICEfaces 3.3.
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r44140. Tomcat 7, FF 34, Chrome 40, IE 11, 10, 9, 8.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r44140. Tomcat 7, FF 34, Chrome 40, IE 11, 10, 9, 8.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Carmen Cristurean
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: