ICEfaces
  1. ICEfaces
  2. ICE-10513

ace:tree, remove dot in between nodes

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: EE-4.0.0.GA, 4.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Any

      Description

      A dot image is being rendered in between tree nodes. This improvement is to remove that dot or make it invisible, for presentation reasons.

      Note that in the showcase application, this dot is not visible.
      1. breadcrumb.PNG
        19 kB
      2. dataTable.PNG
        31 kB
      3. overview.png
        24 kB
      4. tree-node-alignment.jpg
        61 kB

        Activity

        Arturo Zambrano created issue -
        Arturo Zambrano made changes -
        Field Original Value New Value
        Assignee Arturo Zambrano [ artzambrano ]
        Arturo Zambrano made changes -
        Attachment tree-node-alignment.jpg [ 18480 ]
        Ken Fyten made changes -
        Fix Version/s 4.1 [ 11375 ]
        Ken Fyten made changes -
        Fix Version/s EE-4.0.0.GA [ 11171 ]
        Fix Version/s 4.1 [ 11375 ]
        Hide
        Arturo Zambrano added a comment -

        r44119: replaced dot.png for a transparent version.

        Show
        Arturo Zambrano added a comment - r44119: replaced dot.png for a transparent version.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment - - edited

        Reopening for regression:
        Tested ICEfaces 4 trunk r44119 using showcase and QA test apps.
        There are no longer visible drag icons for the inner-most children nodes in the tree. A transparent image is in place and I am able to drag a node without having the mouse pointer directly over it. See attached image overview.png. The red circle indicates when I can mouse over and cause the pointer to display as a move icon, at this point dragging the node can be done.

        Show
        Liana Munroe added a comment - - edited Reopening for regression: Tested ICEfaces 4 trunk r44119 using showcase and QA test apps. There are no longer visible drag icons for the inner-most children nodes in the tree. A transparent image is in place and I am able to drag a node without having the mouse pointer directly over it. See attached image overview.png. The red circle indicates when I can mouse over and cause the pointer to display as a move icon, at this point dragging the node can be done.
        Liana Munroe made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Liana Munroe made changes -
        Attachment overview.png [ 18495 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44124 Thu Feb 26 15:00:18 MST 2015 art.zambrano ICE-10513 reverted to previous dot image
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tree/dot.png
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44127 Thu Feb 26 15:24:08 MST 2015 art.zambrano ICE-10513 adjusted margin to "hide" dot
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tree/tree.css
        Hide
        Arturo Zambrano added a comment -

        r44127: reverted to previous non-transparent dot image; adjusted margin to "hide" dot.

        This dot image is used to "draw" the tree branches. When a node was collapsed "the tip of the branch" was visible. This was fixed by adjusting the top margin that affects this image in tree.css.

        Show
        Arturo Zambrano added a comment - r44127: reverted to previous non-transparent dot image; adjusted margin to "hide" dot. This dot image is used to "draw" the tree branches. When a node was collapsed "the tip of the branch" was visible. This was fixed by adjusting the top margin that affects this image in tree.css.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Liana Munroe made changes -
        Attachment dataTable.PNG [ 18501 ]
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r44132. Tomcat 7, FF 34, Chrome 40, IE 11.

        Noticed a styling issue only when ace:tree is inside ace:dataTable. The center alignment of the cell causes the tree branches of some nodes to not align uniformly. See attached screen shot dataTable.PNG

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r44132. Tomcat 7, FF 34, Chrome 40, IE 11. Noticed a styling issue only when ace:tree is inside ace:dataTable. The center alignment of the cell causes the tree branches of some nodes to not align uniformly. See attached screen shot dataTable.PNG
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44150 Tue Mar 03 09:15:25 MST 2015 art.zambrano ICE-10513, ICE-10514 adjusted tree styling to improve the tree structure; increased height of child nodes container to make it easier to insert child nodes
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tree/TreeRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tree/tree.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44151 Tue Mar 03 09:19:17 MST 2015 art.zambrano ICE-10513, ICE-10514 adjusted tree demos styling
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/tree/treeNested.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/tree/treeReorder.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/tree/treeClient.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/tree/tree.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/tree/treeSelection.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/tree/treeLazy.xhtml
        Hide
        Arturo Zambrano added a comment -

        r44151: adjusted tree styling to improve the tree structure and fixed issue in data table.

        Show
        Arturo Zambrano added a comment - r44151: adjusted tree styling to improve the tree structure and fixed issue in data table.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r44152. Tomcat 7, FF 34, Chrome 40, IE 11.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r44152. Tomcat 7, FF 34, Chrome 40, IE 11.
        Hide
        Liana Munroe added a comment -

        Styling issue in showcase ace:breadCrumbMenu > Overview, all browsers. Was not an issue with r44144.
        See screen shot breadcrumb.PNG

        Show
        Liana Munroe added a comment - Styling issue in showcase ace:breadCrumbMenu > Overview, all browsers. Was not an issue with r44144. See screen shot breadcrumb.PNG
        Liana Munroe made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Liana Munroe made changes -
        Attachment breadcrumb.PNG [ 18585 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44165 Tue Mar 03 12:24:40 MST 2015 art.zambrano ICE-10513, ICE-10514 adjusted tree demos styling
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/breadcrumbmenu/breadcrumbMenu.xhtml
        Hide
        Arturo Zambrano added a comment -

        r44165: fixed styling issue in breadcrumb demo.

        Show
        Arturo Zambrano added a comment - r44165: fixed styling issue in breadcrumb demo.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r44165. Tomcat 7, FF 34, Chrome 40, IE 11, 10, 9, 8.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r44165. Tomcat 7, FF 34, Chrome 40, IE 11, 10, 9, 8.
        Ken Fyten made changes -
        Fix Version/s 4.1 [ 11375 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arturo Zambrano
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: