ICEfaces
  1. ICEfaces
  2. ICE-10498

Showcase -> ace:confirmationDialog demo navigates to the original loaded page w/ MyFaces

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: EE-4.0.0.GA, 4.1
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      ICEfaces 4/trunk svn rvn#44078, MyFaces JSF (2.2.7 or earlier)
    • Assignee Priority:
      P3
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

      Description

      The ace:confirmationDialog can navigate back to the last loaded page when running on Myfaces JSF.

      To reproduce:

      1. Open showcase built with MyFaces
      2. Navigate to a demo page, then reload that page.
      3. Navigate to the ace:confirmationDialog Overview demo
      4. Press "Save" button, choose an option in the dialog, see the response written to the demo page.
      5. Press "Save" button again, choose any option in the dialog, see the page navigate back to the last demo page that was re-loaded.

        Activity

        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Ken Fyten made changes -
        Fix Version/s 4.1 [ 11375 ]
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r44181. Tomcat 7, FF 34, Chrome 40, IE 11.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r44181. Tomcat 7, FF 34, Chrome 40, IE 11.
        Ken Fyten made changes -
        Affects Version/s EE-4.0.0.GA [ 11171 ]
        Ken Fyten made changes -
        Fix Version/s EE-4.0.0.GA [ 11171 ]
        Fix Version/s 4.1 [ 11375 ]
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Mircea Toma added a comment -

        Modified NavigationController so that navigation is avoided when the request is a post-back with no 'exp' parameter defined.

        Show
        Mircea Toma added a comment - Modified NavigationController so that navigation is avoided when the request is a post-back with no 'exp' parameter defined.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44178 Thu Mar 05 12:43:44 MST 2015 mircea.toma ICE-10413, ICE-10498 Avoid navigating if the request is a postback with no 'exp' parameter defined.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/view/navigation/NavigationController.java
        Hide
        Liana Munroe added a comment -

        Checked in fix for progressBar > Push at r44172

        Show
        Liana Munroe added a comment - Checked in fix for progressBar > Push at r44172
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44172 Wed Mar 04 16:16:39 MST 2015 liana.munroe fix required for ICE-10498.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/progressbar/progressBarPush.xhtml
        Hide
        Carmen Cristurean added a comment -

        Checked in fix for dateTimeEntry demos at r. 44171.

        Show
        Carmen Cristurean added a comment - Checked in fix for dateTimeEntry demos at r. 44171.
        Hide
        Ken Fyten added a comment -

        A more efficient solution for showcase may be to modify the NavigationController to not navigate away from the current demo if the navigation parameters are not defined.

        Show
        Ken Fyten added a comment - A more efficient solution for showcase may be to modify the NavigationController to not navigate away from the current demo if the navigation parameters are not defined.
        Ken Fyten made changes -
        Affects Sample App./Tutorial [ 10001 ] Documentation (User Guide, Ref. Guide, etc.),Sample App./Tutorial [ 10003, 10001 ]
        Ken Fyten made changes -
        Assignee Carmen Cristurean [ ccristurean ] Ken Fyten [ ken.fyten ]
        Ken Fyten made changes -
        Fix Version/s 4.1 [ 11375 ]
        Fix Version/s EE-4.0.0.GA [ 11171 ]
        Ken Fyten made changes -
        Affects Version/s EE-4.0.0.GA [ 11171 ]
        Ken Fyten made changes -
        Affects Version/s 4.0 [ 11382 ]
        Affects Version/s EE-4.0.0.GA [ 11171 ]
        Ken Fyten made changes -
        Security Private [ 10001 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44171 Wed Mar 04 15:36:07 MST 2015 carmen.cristurean ICE-10498 - Add f:ajax [execute=@this componentId] to submit buttons to avoid navigation to default overview page.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/date/datelabel.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/date/datepopup.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/date/dateindicator.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/date/datetimeentry.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/date/dateminmax.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/date/datereqstyle.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/date/dateentry.xhtml
        Hide
        Liana Munroe added a comment - - edited

        Seems like most of the demos that use a submit button are failing in the manner described above.
        Other demos failing
        dateTimeEntry > Overview, Popup, TimeEntry, Restrict Min/Max, Label Position, Required Styling.
        submitMonitor > Overview
        list > Selection, Reordering, Drag & Drop
        sliderEntry > Submit.
        dataTable >Selection
        dataExporter > all demos
        tableConfigPanel >all demos
        tabSet >Server side
        dialog >Overview
        breadcrumbMenu > Overview
        contextmenu >Per Component
        menuBar > Dynamic
        growlMessages > Overview

        Often this server warning seen when encountering the issue:
        Mar 04, 2015 2:42:02 PM org.apache.myfaces.shared.context.flash.FlashImpl _manag
        eFlashMapTokens
        WARNING: Identifier for execute FlashMap was lost on the postback, thus FlashSco
        pe information is gone.

        Show
        Liana Munroe added a comment - - edited Seems like most of the demos that use a submit button are failing in the manner described above. Other demos failing dateTimeEntry > Overview, Popup, TimeEntry, Restrict Min/Max, Label Position, Required Styling. submitMonitor > Overview list > Selection, Reordering, Drag & Drop sliderEntry > Submit. dataTable >Selection dataExporter > all demos tableConfigPanel >all demos tabSet >Server side dialog >Overview breadcrumbMenu > Overview contextmenu >Per Component menuBar > Dynamic growlMessages > Overview Often this server warning seen when encountering the issue: Mar 04, 2015 2:42:02 PM org.apache.myfaces.shared.context.flash.FlashImpl _manag eFlashMapTokens WARNING: Identifier for execute FlashMap was lost on the postback, thus FlashSco pe information is gone.
        Carmen Cristurean made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Mircea Toma [ mircea.toma ] Carmen Cristurean [ ccristurean ]
        Hide
        Carmen Cristurean added a comment -

        Re-opening to correct other showcase demos having similar problem:

        1) dateTimeEntry > Indicator Text: user is redirected to previously viewed demo when submitting a new date.
        To reproduce:

        • open showcase built w/MyFaces in a cache-cleared browser.
        • go to dateTimeEntry > Indicator Text.
        • open the popup calendar, select a date and submit.
        • open again the popup calendar, and submit a new date -> redirection to Desktop Showcase Overview page.

        2) progressBar > Push: user is redirected to previously viewed demo when starting, then pausing the progressBar.
        To reproduce:

        • open showcase built w/MyFaces in a cache-cleared browser.
        • go to progressBar > Push.
        • start the progressBar, then click the "pause" button -> redirection to Desktop Showcase Overview page.
        Show
        Carmen Cristurean added a comment - Re-opening to correct other showcase demos having similar problem: 1) dateTimeEntry > Indicator Text: user is redirected to previously viewed demo when submitting a new date. To reproduce: open showcase built w/MyFaces in a cache-cleared browser. go to dateTimeEntry > Indicator Text. open the popup calendar, select a date and submit. open again the popup calendar, and submit a new date -> redirection to Desktop Showcase Overview page. 2) progressBar > Push: user is redirected to previously viewed demo when starting, then pausing the progressBar. To reproduce: open showcase built w/MyFaces in a cache-cleared browser. go to progressBar > Push. start the progressBar, then click the "pause" button -> redirection to Desktop Showcase Overview page.
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r44152. Myfaces libs, Tomcat 7, IE 11, 10, 9, 8, FF 34, Chrome 40.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r44152. Myfaces libs, Tomcat 7, IE 11, 10, 9, 8, FF 34, Chrome 40.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Mircea Toma added a comment -

        Added f:ajax[execute=@this] facets for the yes/no buttons to avoid executing the navigation form.
        Myfaces evaluates this binding in showcase.xhtml

                    <f:viewParam name="exp" required="false"
                                 value="#{navigationModel.componentExample}"/>
        

        during post-back while Mojarra does not. This changes the selected demo after the first post-back to the default page (the component overview) since the parameter evaluates to null.

        Show
        Mircea Toma added a comment - Added f:ajax [execute=@this] facets for the yes/no buttons to avoid executing the navigation form. Myfaces evaluates this binding in showcase.xhtml <f:viewParam name= "exp" required= " false " value= "#{navigationModel.componentExample}" /> during post-back while Mojarra does not. This changes the selected demo after the first post-back to the default page (the component overview) since the parameter evaluates to null.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44148 Mon Mar 02 19:02:20 MST 2015 mircea.toma ICE-10498 Add f:ajax[execute=@this] for the yes/no buttons to avoid executing the navigation form.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/confirmationdialog/confirmationDialog.xhtml
        Hide
        Ken Fyten added a comment -

        Similar issue can also be reproduced using the confirmation aspect of the ace:tabSet Proxy demo:

        tabSet > Proxy, all browsers, Myfaces specific, v. 2.2.5 & 2.2.7
        After entering input and selecting an option to either save or not save the input on the Confirmation tab, user is redirected to the previously viewed demo page.
        This happens only once, in a cleared browser.
        Steps:

        • open showcase Overview page in any browser.
        • navigate to ace:tabSet > Proxy demo.
        • enter input text on Text Entry tab, and click on Confirmation tab -> Confirmation tab displayed.
        • select any option to save or not save the input, click on Outcome tab -> redirection to showcase - Overview page.
        Show
        Ken Fyten added a comment - Similar issue can also be reproduced using the confirmation aspect of the ace:tabSet Proxy demo: tabSet > Proxy, all browsers, Myfaces specific, v. 2.2.5 & 2.2.7 After entering input and selecting an option to either save or not save the input on the Confirmation tab, user is redirected to the previously viewed demo page. This happens only once, in a cleared browser. Steps: open showcase Overview page in any browser. navigate to ace:tabSet > Proxy demo. enter input text on Text Entry tab, and click on Confirmation tab -> Confirmation tab displayed. select any option to save or not save the input, click on Outcome tab -> redirection to showcase - Overview page.
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee Mircea Toma [ mircea.toma ]
        Fix Version/s EE-4.0.0.GA [ 11171 ]
        Affects Sample App./Tutorial [ 10001 ]
        Assignee Priority P3 [ 10012 ]
        Ken Fyten created issue -

          People

          • Assignee:
            Ken Fyten
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: