ICEfaces
  1. ICEfaces
  2. ICE-10492

ice:inputRichText - IE11 Support

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-1.8.2.GA_P07
    • Fix Version/s: EE-1.8.2.GA_P08
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      IE11

      Description

      Currently the CKEditor version used for the ice:inputRichText component does not support IE11. This has been fixed in the ICEfaces 3.x code base by upgrading the CKEditor version. It uses an older version for support of IE7/8 and the newer version for more recent IE releases.

        Activity

        Hide
        Arturo Zambrano added a comment -

        r44796: added CKEditor version 4.7 to be loaded only for IE11, while loading the old version for the rest of the browsers.

        Note that the only available skin on IE11 is kama. Using other skin names will simply default to kama.

        Show
        Arturo Zambrano added a comment - r44796: added CKEditor version 4.7 to be loaded only for IE11, while loading the old version for the rest of the browsers. Note that the only available skin on IE11 is kama. Using other skin names will simply default to kama.
        Hide
        Arturo Zambrano added a comment -

        r44806: modified CKEditor codebases to avoid Javascript errors when trying to dispose of an editor instance whose DOM nodes were already removed.

        Show
        Arturo Zambrano added a comment - r44806: modified CKEditor codebases to avoid Javascript errors when trying to dispose of an editor instance whose DOM nodes were already removed.
        Hide
        Arturo Zambrano added a comment -

        This issue had been reopened to backport this fix to the 3.3 branch, but it wasn't possible to reproduce the issue with said codebase (by modifying the component-showcase tabset demo to include an editor inside one of the tabs). Marking as resolved again.

        Show
        Arturo Zambrano added a comment - This issue had been reopened to backport this fix to the 3.3 branch, but it wasn't possible to reproduce the issue with said codebase (by modifying the component-showcase tabset demo to include an editor inside one of the tabs). Marking as resolved again.
        Hide
        Carmen Cristurean added a comment - - edited

        IF1.8 trunk revision 44808/ IE11, Tomcat 6.0.35 /component-showcase [faceletes-enh] > Rich Text demo:

        1) When clicking the "Source" icon, the source code is rendered in the component, however this causes the IE11 browser to crash.
        User is unable to click any other icon on the demo, and a browser message is displayed at the bottom of the page: "localhost is not responding"; if clicking the "Recover webpage" button, the page is reloaded.

        2) The "Permission denied" console error was still reproduced in IE11/ IE7, when switching toolbar mode between "Basic" and "Default", and also switching tabs between "Rich Text", "Description" and "Source" :
        IE7:
        Line: 12
        Error: Permission denied.

        IE11:
        SCRIPT70: Permission denied
        File: ckeditor.js, Line: 780, Column: 58

        3) Compared to IE7/8, Firefox, Chrome, in IE11 there is no separate "Spell Check As You Type" icon rendered in the component, besides the "Check Spelling" icon.
        Is this an issue?

        4) Spell Checker JS errors:
        a) In IE11 in Spell Checker, after enabling SCAYT, clicking on any of "Options, "Languages", "Dictionaries", "About SCAYT" triggers a JS error:
        SCRIPT5022: SyntaxError
        File: ckeditor.js, Line: 107, Column: 85

        b) In IE7/8, a JS error occurs when using Spell Checker > Spell checking options.
        Steps:

        • type a text in the component.
        • click "Check Spelling" icon -> Spell Check window opens up.
        • click "Options" button on "Spell Check" window.
        • on "Spell checking options" select a few options, then click "Ok" -> JS error:

        IE7:
        Line: 27
        Error: 'JSON' is undefined.

        IE8:
        Message: No such interface supported
        Line: 28
        Char: 3
        Code: 0
        URI: http://s1.webspellchecker.net/spellcheck3/lf/opt_b.js?7193

        Show
        Carmen Cristurean added a comment - - edited IF1.8 trunk revision 44808/ IE11, Tomcat 6.0.35 /component-showcase [faceletes-enh] > Rich Text demo: 1) When clicking the "Source" icon, the source code is rendered in the component, however this causes the IE11 browser to crash. User is unable to click any other icon on the demo, and a browser message is displayed at the bottom of the page: "localhost is not responding"; if clicking the "Recover webpage" button, the page is reloaded. 2) The "Permission denied" console error was still reproduced in IE11/ IE7, when switching toolbar mode between "Basic" and "Default", and also switching tabs between "Rich Text", "Description" and "Source" : IE7: Line: 12 Error: Permission denied. IE11: SCRIPT70: Permission denied File: ckeditor.js, Line: 780, Column: 58 3) Compared to IE7/8, Firefox, Chrome, in IE11 there is no separate "Spell Check As You Type" icon rendered in the component, besides the "Check Spelling" icon. Is this an issue? 4) Spell Checker JS errors: a) In IE11 in Spell Checker, after enabling SCAYT, clicking on any of "Options, "Languages", "Dictionaries", "About SCAYT" triggers a JS error: SCRIPT5022: SyntaxError File: ckeditor.js, Line: 107, Column: 85 b) In IE7/8, a JS error occurs when using Spell Checker > Spell checking options. Steps: type a text in the component. click "Check Spelling" icon -> Spell Check window opens up. click "Options" button on "Spell Check" window. on "Spell checking options" select a few options, then click "Ok" -> JS error: IE7: Line: 27 Error: 'JSON' is undefined. IE8: Message: No such interface supported Line: 28 Char: 3 Code: 0 URI: http://s1.webspellchecker.net/spellcheck3/lf/opt_b.js?7193
        Hide
        Arturo Zambrano added a comment -

        r44962: Changed the CKEditor version for IE11 from 4.7 to 4.3.3, which is the same version used on the 4.x trunk and the 3.3 ee maintenance branch. Some fixes for some known issues were applied as well. Also, modified the previous fix in this JIRA to avoid issue with Source button. These changes should solve all the issues on IE11.

        The issue #3 above is not really an issue. That's just how the buttons are arranged in the CKEditor after version 4.0. The same functions are still available in the drop down menu.

        Show
        Arturo Zambrano added a comment - r44962: Changed the CKEditor version for IE11 from 4.7 to 4.3.3, which is the same version used on the 4.x trunk and the 3.3 ee maintenance branch. Some fixes for some known issues were applied as well. Also, modified the previous fix in this JIRA to avoid issue with Source button. These changes should solve all the issues on IE11. The issue #3 above is not really an issue. That's just how the buttons are arranged in the CKEditor after version 4.0. The same functions are still available in the drop down menu.
        Hide
        Arturo Zambrano added a comment -

        r44967: fix to access global variable through the window object, in order to avoid error on IE7.

        Show
        Arturo Zambrano added a comment - r44967: fix to access global variable through the window object, in order to avoid error on IE7.
        Hide
        Arturo Zambrano added a comment -

        As for issue #4, those errors occur in the third-party service Javascript code (http://s1.webspellchecker.net/spellcheck3/lf/opt_b.js) and there's nothing we can do about that. As for issue #2 I just couldn't reproduce that issue (on a real IE7 browser).

        Show
        Arturo Zambrano added a comment - As for issue #4, those errors occur in the third-party service Javascript code ( http://s1.webspellchecker.net/spellcheck3/lf/opt_b.js ) and there's nothing we can do about that. As for issue #2 I just couldn't reproduce that issue (on a real IE7 browser).
        Hide
        Carmen Cristurean added a comment -

        ICEfaces 1.8 revision 44976/ component-showcase [facelets-enh]:

        Issue 1) can no longer be reproduced.

        Issue 2) is still reproducible: in IE11/IE8, must change the Toolbar Mode and the tabs alternatively for 2 or 3 times.

        In IE10/IE9 other errors were immediately reproducible by changing Toolbar Mode to "Basic":
        SCRIPT5007: Unable to get value of the property 'open': object is null or undefined
        about:blank, line 1 character 1
        SCRIPT16389: Unspecified error.
        ieerror.js, line 66 character 1

        In IE11, Check Spelling feature is not functional, as it fails to load any suggestions; also, after attempting to use Spell Check, the "About CKEditor" window opens up blank.
        Not an issue in FF34, Chrome43, or other IE browsers.
        Steps:

        • open the Rich Text demo in IE11.
        • type "teste" in the inputRichText component.
        • enable SCAYT, then click "Check Spelling" -> the Spell Checker does not provide any suggesstions (it displays "loading...).
        • click "Finish Checking" on the Spell Check poup window -> the window does not close, so click "Cancel" to close the window.
        • change Toolbar MOde to "Basic", then click the "About CKEditor" icon -> the "About CKEditor" popup opens up blank.
          This window is also blank if changing back the Tollbar Mode to "Default".
        Show
        Carmen Cristurean added a comment - ICEfaces 1.8 revision 44976/ component-showcase [facelets-enh] : Issue 1) can no longer be reproduced. Issue 2) is still reproducible: in IE11/IE8, must change the Toolbar Mode and the tabs alternatively for 2 or 3 times. In IE10/IE9 other errors were immediately reproducible by changing Toolbar Mode to "Basic": SCRIPT5007: Unable to get value of the property 'open': object is null or undefined about:blank, line 1 character 1 SCRIPT16389: Unspecified error. ieerror.js, line 66 character 1 In IE11, Check Spelling feature is not functional, as it fails to load any suggestions; also, after attempting to use Spell Check, the "About CKEditor" window opens up blank. Not an issue in FF34, Chrome43, or other IE browsers. Steps: open the Rich Text demo in IE11. type "teste" in the inputRichText component. enable SCAYT, then click "Check Spelling" -> the Spell Checker does not provide any suggesstions (it displays "loading...). click "Finish Checking" on the Spell Check poup window -> the window does not close, so click "Cancel" to close the window. change Toolbar MOde to "Basic", then click the "About CKEditor" icon -> the "About CKEditor" popup opens up blank. This window is also blank if changing back the Tollbar Mode to "Default".
        Hide
        Arturo Zambrano added a comment -

        r44987: fixes for errors on IE8/IE9/IE10 when switching to the basic toolbar; fix for spell checking dialog on IE11.

        I still can't reproduce the issue on IE11, please provide specific, detailed steps to reproduce the issue. Also, let me know what machine you tested on.

        The issue with the About CKEditor dialog is still present, but given that this doesn't affect functionality, it will be given lower priority.

        Show
        Arturo Zambrano added a comment - r44987: fixes for errors on IE8/IE9/IE10 when switching to the basic toolbar; fix for spell checking dialog on IE11. I still can't reproduce the issue on IE11, please provide specific, detailed steps to reproduce the issue. Also, let me know what machine you tested on. The issue with the About CKEditor dialog is still present, but given that this doesn't affect functionality, it will be given lower priority.
        Hide
        Arturo Zambrano added a comment -

        r45063: added fallback method of destroying previous instance.

        This commit should fix the issues when switching between toolbar modes and tabs.

        Show
        Arturo Zambrano added a comment - r45063: added fallback method of destroying previous instance. This commit should fix the issues when switching between toolbar modes and tabs.
        Hide
        Arturo Zambrano added a comment -

        r45077: committed fixes for error popups when using the spellchecking plug-in.

        Indeed, those errors are very random, and it's not always possible to reproduce them. I noticed that these errors were more likely to happen when quickly clicking different buttons and menu options, without giving a good pause for all the operations to complete before clicking something else. They also seemed more likely to happen after clearing the browser's cache.

        These commits try to fix those errors that we know about. There might still be other random error messages, but they don't affect the normal functioning of the editor. It could also be that these errors are seen on our test machines because they are slower. I couldn't reproduce these errors using IE11 in previous versions modes.

        As for the last issue, the error occurs in the third-party website code, and we don't have any control over it.

        Show
        Arturo Zambrano added a comment - r45077: committed fixes for error popups when using the spellchecking plug-in. Indeed, those errors are very random, and it's not always possible to reproduce them. I noticed that these errors were more likely to happen when quickly clicking different buttons and menu options, without giving a good pause for all the operations to complete before clicking something else. They also seemed more likely to happen after clearing the browser's cache. These commits try to fix those errors that we know about. There might still be other random error messages, but they don't affect the normal functioning of the editor. It could also be that these errors are seen on our test machines because they are slower. I couldn't reproduce these errors using IE11 in previous versions modes. As for the last issue, the error occurs in the third-party website code, and we don't have any control over it.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: