ICEfaces
  1. ICEfaces
  2. ICE-10489

ace:tree - Node alignment issue

          Details

            Description

            When displaying an ace:tree with a mixture of nodes with children and nodes with no children. The leaf nodes are rendered misaligned with the nodes with children nodes.

            This is caused by the leaf nodes not rendering the expand/contract icon (+/-).
            1. Zip Archive
              Case13296Example.zip
              23 kB
              Arran Mccullough
            2. Zip Archive
              Case13296ExampleWAR.zip
              9.32 MB
              Arran Mccullough
            1. screenshot-ice10489-gap.png
              35 kB
            2. screenshot-ice10489-no-gap.png
              35 kB
            3. tree-node-alignment.jpg
              61 kB

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case and image that shows this issue.

              Show
              Arran Mccullough added a comment - Attached test case and image that shows this issue.
              Arran Mccullough made changes -
              Field Original Value New Value
              Attachment Case13296Example.zip [ 18289 ]
              Attachment Case13296ExampleWAR.zip [ 18290 ]
              Attachment tree-node-alignment.jpg [ 18291 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ]
              Fix Version/s EE-4.0.0.GA [ 11171 ]
              Fix Version/s EE-3.3.0.GA_P03 [ 11572 ]
              Assignee Priority P2 [ 10011 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #44064 Fri Feb 13 13:36:18 MST 2015 art.zambrano ICE-10489 added margin to root leaf nodes so they align with root nodes that have children (which display a contracted/expanded icon)
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tree/TreeRenderer.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed fix to 4.0 trunk at revision 44064 and to 3.3 EE maintenance branch at revision 44065.

              Added margin to root leaf nodes so they align with root nodes that have children (which display a contracted/expanded icon). This margin is only applied to root nodes. When it was applied to child nodes, it actually didn't look well, since it formed a gap between the tree "branch" and the label and it could also lead to confusion as appearing to be under a sibling that has the contracted icon.

              Show
              Arturo Zambrano added a comment - Committed fix to 4.0 trunk at revision 44064 and to 3.3 EE maintenance branch at revision 44065. Added margin to root leaf nodes so they align with root nodes that have children (which display a contracted/expanded icon). This margin is only applied to root nodes. When it was applied to child nodes, it actually didn't look well, since it formed a gap between the tree "branch" and the label and it could also lead to confusion as appearing to be under a sibling that has the contracted icon.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Arturo Zambrano made changes -
              Attachment screenshot-ice10489-gap.png [ 18391 ]
              Arturo Zambrano made changes -
              Attachment screenshot-ice10489-no-gap.png [ 18392 ]
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified in IE11, Chrome40, FF34, with IF4 trunk r44097 and EE-3.3.0-maintenance branch r44065.

              Show
              Carmen Cristurean added a comment - Verified in IE11, Chrome40, FF34, with IF4 trunk r44097 and EE-3.3.0-maintenance branch r44065.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #44111 Tue Feb 24 11:24:48 MST 2015 art.zambrano ICE-10489 added left margin to all tree nodes
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tree/TreeRenderer.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Added left margin to all leaf nodes in the tree (not only roots) at revisions 44111 and 44112.

              Testing notes: please verify again, this time all child nodes will also have a margin.

              Show
              Arturo Zambrano added a comment - Added left margin to all leaf nodes in the tree (not only roots) at revisions 44111 and 44112. Testing notes: please verify again, this time all child nodes will also have a margin.
              Ken Fyten made changes -
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: