ICEfaces
  1. ICEfaces
  2. ICE-10483

ace:comboBox inside ace:tabSet styling issue

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: EE-4.0.0.GA, 4.1
    • Component/s: ACE-Components, Sample Apps
    • Labels:
      None
    • Environment:
      ICEfaces4 trunk rev. 44025
      Browsers: all
      Server: Tomcat 7.0.42
    • Assignee Priority:
      P3
    • Affects:
      Sample App./Tutorial

      Description

      QA test app: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/comboBox
      Test page: /comboBoxAceTabSet.jsf

      Styling issue when comboBox is inside ace:tabSet. All browsers, does not seem to be an issue when comboBox is inside other components.

      When first loading the page the arrow icon is not centered (image1).
      After making a selection the arrow is aligned properly (image2).
      After changing to tab 2 then back to tab 1 the arrow moves back to the top (image3).
      1. image1.PNG
        10 kB
      2. image2.PNG
        12 kB
      3. image3.PNG
        18 kB
      4. screenshot-ice10483-1.png
        75 kB

        Activity

        Carmen Cristurean created issue -
        Carmen Cristurean made changes -
        Field Original Value New Value
        Attachment image1.PNG [ 18284 ]
        Attachment image2.PNG [ 18285 ]
        Carmen Cristurean made changes -
        Description QA test app: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/comboBox
        Test page: /comboBoxAceTabSet.jsf

        Styling issue when comboBox is inside ace:tabSet. All browsers, does not seem to be an issue when comboBox is inside other components.

        When first loading the page the arrow icon is not centered (image1).
        After making a selection the arrow is aligned properly (image2).
        After changing to tab 2 then back to tab 1 the arrow moves back to the top (image1).
        QA test app: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/comboBox
        Test page: /comboBoxAceTabSet.jsf

        Styling issue when comboBox is inside ace:tabSet. All browsers, does not seem to be an issue when comboBox is inside other components.

        When first loading the page the arrow icon is not centered (image1).
        After making a selection the arrow is aligned properly (image2).
        After changing to tab 2 then back to tab 1 the arrow moves back to the top (image3).
        Carmen Cristurean made changes -
        Attachment image3.PNG [ 18286 ]
        Carmen Cristurean made changes -
        Fix Version/s EE-4.0.0.GA [ 11171 ]
        Ken Fyten made changes -
        Assignee Arturo Zambrano [ artzambrano ]
        Priority Major [ 3 ] Trivial [ 5 ]
        Assignee Priority P3 [ 10012 ]
        Hide
        Arturo Zambrano added a comment -

        r44095: fix to avoid calculating heights of down-arrow button, in order to make it display correctly inside ace:tabSet; changed use of Themeroller down-arrow icon for Font Awesome chevron-down character.

        Show
        Arturo Zambrano added a comment - r44095: fix to avoid calculating heights of down-arrow button, in order to make it display correctly inside ace:tabSet; changed use of Themeroller down-arrow icon for Font Awesome chevron-down character.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Affects Version/s 4.0 [ 11382 ]
        Affects Version/s EE-4.0.0.GA [ 11171 ]
        Ken Fyten made changes -
        Security Private [ 10001 ]
        Hide
        Carmen Cristurean added a comment -

        Verified with IF4 trunk r44095 in IE11, FF34, Chrome40.

        Show
        Carmen Cristurean added a comment - Verified with IF4 trunk r44095 in IE11, FF34, Chrome40.
        Hide
        Ken Fyten added a comment -

        Re-opened to address an issue where the height of the comboBox and it's list items is not tall enough. Should match the component and row height of the ace:selectMenu.

        Show
        Ken Fyten added a comment - Re-opened to address an issue where the height of the comboBox and it's list items is not tall enough. Should match the component and row height of the ace:selectMenu.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Arturo Zambrano made changes -
        Attachment screenshot-ice10483-1.png [ 18481 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44135 Fri Feb 27 15:21:00 MST 2015 art.zambrano ICE-10483 increased height of comboboxes
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/combobox/comboBoxFacet.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/combobox/comboBoxOverview.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/combobox/comboBoxFiltering.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/combobox/comboBoxReqStyle.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/combobox/comboBoxIndicator.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/combobox/comboBoxLabel.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44136 Fri Feb 27 15:27:11 MST 2015 art.zambrano ICE-10483 changed default height of ace:comboBox list to stretch to fit all contents
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/combobox/ComboBoxMeta.java
        Hide
        Arturo Zambrano added a comment -

        r44135: increased height of comboboxes in the showcase application.

        Outside the showcase, ace:selectMenu and ace:comboBox have the same height. In the showcase, the combobox appeared 2px smaller because of some general custom styling in the app. All combobox instances were modified to increase their height.

        r44136: changed default height of ace:comboBox list to stretch to fit all contents, like ace:autoCompleteEntry and ace:selectMenu.

        Show
        Arturo Zambrano added a comment - r44135: increased height of comboboxes in the showcase application. Outside the showcase, ace:selectMenu and ace:comboBox have the same height. In the showcase, the combobox appeared 2px smaller because of some general custom styling in the app. All combobox instances were modified to increase their height. r44136: changed default height of ace:comboBox list to stretch to fit all contents, like ace:autoCompleteEntry and ace:selectMenu.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r44140. Tomcat 7. FF 34, Chrome 40, IE 11, 10, 9, 8.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r44140. Tomcat 7. FF 34, Chrome 40, IE 11, 10, 9, 8.
        Ken Fyten made changes -
        Affects Sample App./Tutorial [ 10001 ]
        Component/s Sample Apps [ 10010 ]
        Component/s ACE-Components [ 10050 ]
        Ken Fyten made changes -
        Component/s ACE-Components [ 10050 ]
        Ken Fyten made changes -
        Fix Version/s 4.1 [ 11375 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Carmen Cristurean
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: