ICEfaces
  1. ICEfaces
  2. ICE-10473

Increase height of background image for active and hover states in Sam theme

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Trivial Trivial
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P02, 4.0
          • Fix Version/s: EE-4.0.0.GA, EE-3.3.0.GA_P03, 4.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Any
          • Assignee Priority:
            P2

            Description

            While working on ICE-10333, it was found that the height of the ui-state-active and ui-state-hover background images is not tall enough in some cases. For example, an ace:dataTable that uses ace:columnGroup, ace:row, and stacked headers, produces very tall column headers, as in the attached screenshot. When these headers have the active or hover state, the corresponding background images in the sprite aren't tall enough to cover the full height of such headers. It is necessary to have background images for these states that will cover taller elements.

            This is visible in the ace:dataTable test application on the columnHeaderOrdering.jsf test page.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #44000 Tue Feb 03 13:38:36 MST 2015 art.zambrano ICE-10473 increased height of active and hover background images
              Files Changed
              Commit graph ADD /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/themes/sam/images/ui-hover.png
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/themes/sam/theme.css
              Commit graph ADD /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/themes/sam/images/ui-active.png
              Arturo Zambrano created issue -
              Arturo Zambrano made changes -
              Field Original Value New Value
              Assignee Arturo Zambrano [ artzambrano ]
              Arturo Zambrano made changes -
              Fix Version/s EE-4.0.0.GA [ 11171 ]
              Arturo Zambrano made changes -
              Description The height of the ui-state-active and ui-state-hover background images is not tall enough in some cases. For example, an ace:dataTable that uses ace:columnGroup, ace:row, and stacked headers, produces very tall column headers, as in the attached screenshot. When these headers have the active or hover state, the corresponding background images in the sprite aren't tall enough to cover the full height of such headers. It is necessary to have background images for these states that will cover taller elements. The height of the ui-state-active and ui-state-hover background images is not tall enough in some cases. For example, an ace:dataTable that uses ace:columnGroup, ace:row, and stacked headers, produces very tall column headers, as in the attached screenshot. When these headers have the active or hover state, the corresponding background images in the sprite aren't tall enough to cover the full height of such headers. It is necessary to have background images for these states that will cover taller elements.

              This is visible in the ace:dataTable test application on the columnHeaderOrdering.jsf test page.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r44000: increased height of active and hover background images in the 4.0 trunk.

              Show
              Arturo Zambrano added a comment - r44000: increased height of active and hover background images in the 4.0 trunk.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Arturo Zambrano made changes -
              Attachment screenshot-ice10473-after.png [ 18180 ]
              Attachment screenshot-ice10473-before.png [ 18181 ]
              Ken Fyten made changes -
              Summary Increase height of background image for active and hover states in sam theme Increase height of background image for active and hover states in Sam theme
              Ken Fyten made changes -
              Priority Major [ 3 ] Minor [ 4 ]
              Ken Fyten made changes -
              Priority Minor [ 4 ] Trivial [ 5 ]
              Arturo Zambrano made changes -
              Description The height of the ui-state-active and ui-state-hover background images is not tall enough in some cases. For example, an ace:dataTable that uses ace:columnGroup, ace:row, and stacked headers, produces very tall column headers, as in the attached screenshot. When these headers have the active or hover state, the corresponding background images in the sprite aren't tall enough to cover the full height of such headers. It is necessary to have background images for these states that will cover taller elements.

              This is visible in the ace:dataTable test application on the columnHeaderOrdering.jsf test page.               		While working on ICE-10333, it was found that the height of the ui-state-active and ui-state-hover background images is not tall enough in some cases. For example, an ace:dataTable that uses ace:columnGroup, ace:row, and stacked headers, produces very tall column headers, as in the attached screenshot. When these headers have the active or hover state, the corresponding background images in the sprite aren't tall enough to cover the full height of such headers. It is necessary to have background images for these states that will cover taller elements.

              This is visible in the ace:dataTable test application on the columnHeaderOrdering.jsf test page.
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces 4 trunk r44009, Tomcat 7, IE 8, 9, 10, 11, FF 34, Chrome 40. Issue still exists in ee-3.3.0 maintenance branch.

              Show
              Liana Munroe added a comment - Verified ICEfaces 4 trunk r44009, Tomcat 7, IE 8, 9, 10, 11, FF 34, Chrome 40. Issue still exists in ee-3.3.0 maintenance branch.
              Hide
              Permalink
              Ken Fyten added a comment -

              Re-opened to backport this fix to the 3.3. maintenance branch.

              Show
              Ken Fyten added a comment - Re-opened to backport this fix to the 3.3. maintenance branch.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Assignee Priority P2 [ 10011 ]
              Ken Fyten made changes -
              Fix Version/s EE-3.3.0.GA_P03 [ 11572 ]
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed improvement to 3.3 EE maintenance branch at revision 44015.

              Show
              Arturo Zambrano added a comment - Committed improvement to 3.3 EE maintenance branch at revision 44015.
              Arturo Zambrano made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces ee-3.3.0 maintenance branch r44022, Tomcat 7, IE 8, 9, 10, 11, FF 34, Chrome 40.

              Show
              Liana Munroe added a comment - Verified ICEfaces ee-3.3.0 maintenance branch r44022, Tomcat 7, IE 8, 9, 10, 11, FF 34, Chrome 40.
              Ken Fyten made changes -
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arturo Zambrano
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: