ICEfaces
  1. ICEfaces
  2. ICE-10440

Server error seen when undeploying showcase and ace comps from Tomcat7

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-4.0.0.GA
          • Fix Version/s: EE-4.0.0.GA
          • Component/s: ACE-Components, Sample Apps
          • Labels:
            None
          • Environment:
            Tomcat 7 ICEfaces 4 trunk r 43886
          • Assignee Priority:
            P2

            Description

            Server error seen recently when un-deploying ICEfaces 4 ace comps and showcase .war files. This was seen with comboBox, selectMenu, SimpleSelectOneMenu and other random (not recently touched) components.
            Looked at an older revision of these files (43630) on xp02 and did not see the server error. This error is different from the error mentioned in ICE-10377 (marked invalid)
            SEVERE: The web application [/tree] created a ThreadLocal with key of type [org.
            icefaces.ace.context.RequestContext$1] (value [org.icefaces.ace.context.RequestC
            ontext$1@b52a10c]) and a value of type [org.icefaces.ace.context.DefaultRequestC
            ontext] (value [org.icefaces.ace.context.DefaultRequestContext@55c870dc]) but fa
            iled to remove it when the web application was stopped. Threads are going to be renewed over time to try and avoid a probable memory leak.

              Activity

              Ascending order - Click to sort in descending order
              Liana Munroe created issue -
              Liana Munroe made changes -
              Field Original Value New Value
              Description Server error seen recently when un-deploying ICEfaces 4 ace comps and showcase .war files. This was seen with comboBox, selectMenu, SimpleSelectOneMenu and other random (not recently touched) components.
              Looked at an older revision of these files (43630) on xp02 and did not see the server error. This error is different from the error mentioned in ICE-10377 (marked invalid)
              SEVERE: The web application [/tree] created a ThreadLocal with key of type [org.
              icefaces.ace.context.RequestContext$1] (value [org.icefaces.ace.context.RequestC
              ontext$1@b52a10c]) and a value of type [org.icefaces.ace.context.DefaultRequestC
              ontext] (value [org.icefaces.ace.context.DefaultRequestContext@55c870dc]) but fa
              iled to remove it when the web application was stopped. Threads are going to be renewed over time to try and avoid a probable memory leak.

              Undeploying the same .war files from ee-3.3.0 maintenance branch produce the following errors:
              INFO: Undeploying context [/showcase]
              Jan 08, 2015 5:24:17 PM org.apache.catalina.loader.WebappClassLoader clearReferencesThreads
              SEVERE: The web application [/showcase] appears to have started a thread named [WindowScopeManager timer] but has failed to stop it. This is very likely to create a memory leak.
              INFO: Undeploying context [/tree]
              Jan 08, 2015 5:28:09 PM org.apache.catalina.loader.WebappClassLoader clearReferencesThreads
              SEVERE: The web application [/tree] appears to have started a thread named [WindowScopeManager timer] but has failed to stop it. This is very likely to create a memory leak.




              		Server error seen recently when un-deploying ICEfaces 4 ace comps and showcase .war files. This was seen with comboBox, selectMenu, SimpleSelectOneMenu and other random (not recently touched) components.
              Looked at an older revision of these files (43630) on xp02 and did not see the server error. This error is different from the error mentioned in ICE-10377 (marked invalid)
              SEVERE: The web application [/tree] created a ThreadLocal with key of type [org.
              icefaces.ace.context.RequestContext$1] (value [org.icefaces.ace.context.RequestC
              ontext$1@b52a10c]) and a value of type [org.icefaces.ace.context.DefaultRequestC
              ontext] (value [org.icefaces.ace.context.DefaultRequestContext@55c870dc]) but fa
              iled to remove it when the web application was stopped. Threads are going to be renewed over time to try and avoid a probable memory leak.

              Liana Munroe made changes -
              Affects Version/s EE-4.0.0.GA [ 11171 ]
              Affects Version/s EE-3.3.0.GA_P02 [ 11371 ]
              Affects Version/s 4.0 [ 11382 ]
              Ken Fyten made changes -
              Fix Version/s EE-4.0.0.GA [ 11171 ]
              Ken Fyten made changes -
              Assignee Mircea Toma [ mircea.toma ]
              Assignee Priority P2 [ 10011 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #43895 Mon Jan 12 16:27:49 MST 2015 mircea.toma ICE-10440 Invoke PartialViewContext.processPartial on the enclosing contexts during render phase as well to give a chance to these context to add their own accumulated updates and also do their cleanup.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #43896 Mon Jan 12 17:36:45 MST 2015 mircea.toma ICE-10440 Revert previous fix.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java
              Mircea Toma made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Mircea Toma made changes -
              Comment [ Invoke _PartialViewContext.processPartial_ on the enclosing contexts during render phase as well to give a chance to these contexts to add their own accumulated updates and also do their cleanup.
              _CallbackPartialResponseWriter_ was relying on _endDocument_ call to cleanup the _ThreadLocal_. ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #43898 Tue Jan 13 05:16:14 MST 2015 mircea.toma ICE-10440 Acquire the top partial response writer when generating the dom diff updates to make sure the nested writers also get invoked.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java
              Hide
              Permalink
              Mircea Toma added a comment -

              Acquire the top partial response writer when generating the dom diff updates to make sure the nested writers also get invoked. This way CallbackPartialResponseWriter will run and have a chance to clear up the thread local.

              Show
              Mircea Toma added a comment - Acquire the top partial response writer when generating the dom diff updates to make sure the nested writers also get invoked. This way CallbackPartialResponseWriter will run and have a chance to clear up the thread local.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces 4 trunk r43898. Tomcat 7, IE 11, FF 34, Chrome 39.

              Show
              Liana Munroe added a comment - Verified ICEfaces 4 trunk r43898. Tomcat 7, IE 11, FF 34, Chrome 39.
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Liana Munroe
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: