ICEfaces
  1. ICEfaces
  2. ICE-10431

ace:rowEditor - Can't edit after changing rendered attribute

          Details

            Description

            In this scenario an ace:dataTable is set to be editable under certain circumstances. This is toggled by changing the rendered attribute of the ace:rowEditor component. If the rows are rendered with this set to false, and then changed to true, it is not possible to put the table in it's edit mode. Clicking the pencil icon has no effect.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case that shows issue.

              Steps:

              • Load welcomeICEfaces.jsf
              • Table is loaded with nothing in the edit row.
              • Click on the Table Two button, table is now loaded with new content that includes the rowEditor button.
              • Clicking on the pencil icon does nothing.
              Show
              Arran Mccullough added a comment - Attached test case that shows issue. Steps: Load welcomeICEfaces.jsf Table is loaded with nothing in the edit row. Click on the Table Two button, table is now loaded with new content that includes the rowEditor button. Clicking on the pencil icon does nothing.
              Arran Mccullough made changes -
              Field Original Value New Value
              Attachment Case13225Example2.zip [ 17702 ]
              Attachment Case13225Example2.war [ 17703 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ]
              Fix Version/s EE-4.0.0.GA [ 11171 ]
              Fix Version/s EE-3.3.0.GA_P03 [ 11572 ]
              Assignee Priority P1 [ 10010 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #43887 Thu Jan 08 15:22:59 MST 2015 art.zambrano ICE-10431 moved setup of rowEditor events to a dynamic Javascript call instead of constructor, in order to (re)apply behaviour to rowEditor buttons in the table, if any, after they are set rendered=true
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r43887: Committed fix to 4.0 trunk.

              The issue was that the rowEditor buttons client behaviours were only set in the constructor, if there were any row editors in the table (client-side). So, if in the first table there were no row editors, this behaviour wasn't being applied to the table, which is actually a delegate event (an event listener applied to a parent element that fires when the event bubbles up). The fix consisted in moving the setup of rowEditor events to a dynamic Javascript call, in order to (re)apply behaviour to rowEditor buttons in the table, if any, after they are set rendered=true.

              Show
              Arturo Zambrano added a comment - r43887: Committed fix to 4.0 trunk. The issue was that the rowEditor buttons client behaviours were only set in the constructor, if there were any row editors in the table (client-side). So, if in the first table there were no row editors, this behaviour wasn't being applied to the table, which is actually a delegate event (an event listener applied to a parent element that fires when the event bubbles up). The fix consisted in moving the setup of rowEditor events to a dynamic Javascript call, in order to (re)apply behaviour to rowEditor buttons in the table, if any, after they are set rendered=true.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #43888 Thu Jan 08 17:26:20 MST 2015 art.zambrano ICE-10431 moved setup of rowEditor events to a dynamic Javascript call instead of constructor, in order to (re)apply behaviour to rowEditor buttons in the table, if any, after they are set rendered=true
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRendererUtil.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              43888: committed further improvement to 4.0 to only perform the dynamic Javascript call if the table contains at least one RowEditor component.
              43889: ported complete fix to 3.3 EE maintenance branch.

              Show
              Arturo Zambrano added a comment - 43888: committed further improvement to 4.0 to only perform the dynamic Javascript call if the table contains at least one RowEditor component. 43889: ported complete fix to 3.3 EE maintenance branch.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified using the attached test case, ICEfaces 4 trunk r43890. Tomcat 7, IE 11, FF 34, Chrome 39.
              When testing with ee-3.3.0 maintenance branch r43891 the issue remains.

              Show
              Liana Munroe added a comment - Verified using the attached test case, ICEfaces 4 trunk r43890. Tomcat 7, IE 11, FF 34, Chrome 39. When testing with ee-3.3.0 maintenance branch r43891 the issue remains.
              Liana Munroe made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r43892: modified approach in 3.3 maintenance branch to use widgetVar, instead of ice.ace.instance.

              Show
              Arturo Zambrano added a comment - r43892: modified approach in 3.3 maintenance branch to use widgetVar, instead of ice.ace.instance.
              Arturo Zambrano made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces ee-3.3.0 maintenance branch r43892. Tomcat 7, IE 11, FF 34, Chrome 39.

              Show
              Liana Munroe added a comment - Verified ICEfaces ee-3.3.0 maintenance branch r43892. Tomcat 7, IE 11, FF 34, Chrome 39.
              Ken Fyten made changes -
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: