ICEfaces
  1. ICEfaces
  2. ICE-10429

New ace:theme component - Adds ability to set 'org.icefaces.ace.theme' at a page level

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P02, 4.0
    • Fix Version/s: EE-4.0.0.GA, 4.1
    • Component/s: ICECORE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      Feature Request: Add the ability to set the org.icefaces.ace.theme context param at a page level via an icecore component tag.

      The reason for this is that even with no ICEfaces components used on the page, it will still load the Theme CSS in the head. This can be turned off by setting the context param but this is applied to all pages.

        Activity

        Arran Mccullough created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee Mircea Toma [ mircea.toma ]
        Fix Version/s 4.1 [ 11375 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43959 Mon Jan 26 16:28:57 MST 2015 mircea.toma ICE-10429 Introduced ace:config component that can be used to configure the look&feel theme at page level.
        Files Changed
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config/ConfigHandler.java
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config/Config.java
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config/ConfigRenderer.java
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/themeselect/ThemeSymbolicResourceHandler.java
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config/ConfigMeta.java
        Hide
        Mircea Toma added a comment - - edited

        Introduced ace:config component that can be used to configure the look&feel theme at page level. Also modified ThemeSymbolicResourceHandler to read the selected theme from the view map in case the theme is set per page.

        Usage:

        <html>
        ...
        <ace:config theme="cupertino"/>
        ...
        </h:body>
        </html>
        
        Show
        Mircea Toma added a comment - - edited Introduced ace:config component that can be used to configure the look&feel theme at page level. Also modified ThemeSymbolicResourceHandler to read the selected theme from the view map in case the theme is set per page. Usage: <html> ... <ace:config theme= "cupertino" /> ... </h:body> </html>
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Mircea Toma made changes -
        Affects Documentation (User Guide, Ref. Guide, etc.) [ 10003 ]
        Hide
        Liana Munroe added a comment -

        New test application added to
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/ACEconfig. Three separate themed pages are loaded using the ace:config tag.

        Show
        Liana Munroe added a comment - New test application added to http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/ACEconfig . Three separate themed pages are loaded using the ace:config tag.
        Ken Fyten made changes -
        Fix Version/s EE-4.0.0.GA [ 11171 ]
        Fix Version/s 4.1 [ 11375 ]
        Hide
        Ken Fyten added a comment -

        Let's rename this new component ace:theme and the value=xxx can hold the theme to be loaded.

        Show
        Ken Fyten added a comment - Let's rename this new component ace:theme and the value=xxx can hold the theme to be loaded.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Affects Documentation (User Guide, Ref. Guide, etc.) [ 10003 ] Documentation (User Guide, Ref. Guide, etc.),Sample App./Tutorial,Compatibility/Configuration [ 10003, 10001, 10002 ]
        Assignee Priority P2 [ 10011 ]
        Ken Fyten made changes -
        Summary Add ability to set 'org.icefaces.ace.theme' at a page level New ace:theme component - Adds ability to set 'org.icefaces.ace.theme' at a page level
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43995 Mon Feb 02 19:21:56 MST 2015 mircea.toma ICE-10429 Rename ace:config component to ace:theme.
        Files Changed
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config/ThemeHandler.java
        Commit graph DEL /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config/ConfigHandler.java
        Commit graph DEL /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config/Config.java
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config/Theme.java
        Commit graph DEL /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config/ConfigRenderer.java
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config/ThemeMeta.java
        Commit graph DEL /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config/ConfigMeta.java
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config/ThemeRenderer.java
        Hide
        Mircea Toma added a comment -

        Renamed ace:config component to ace:theme.

        Show
        Mircea Toma added a comment - Renamed ace:config component to ace:theme .
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Carmen Cristurean added a comment - - edited

        Renamed ACEConfig QA test application to "theme", updated to use ace:theme component.
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/theme

        Verified with IF4 trunk rev. 43997 in Chrome39, IE11, FF34.

        Show
        Carmen Cristurean added a comment - - edited Renamed ACEConfig QA test application to "theme", updated to use ace:theme component. http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/theme Verified with IF4 trunk rev. 43997 in Chrome39, IE11, FF34.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44068 Mon Feb 16 11:26:41 MST 2015 mircea.toma ICE-10429 Rename package name.
        Files Changed
        Commit graph DEL /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/config
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/theme/ThemeHandler.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/theme/Theme.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/theme/ThemeRenderer.java
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/theme
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/theme/ThemeMeta.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44069 Mon Feb 16 11:54:30 MST 2015 mircea.toma ICE-10429 Updated TLS documentation and added Wiki component description.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/theme/ThemeMeta.java
        Hide
        Mircea Toma added a comment -

        Updated TLD documentation and added Wiki component description.

        Show
        Mircea Toma added a comment - Updated TLD documentation and added Wiki component description.
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Liana Munroe made changes -
        Attachment theme.PNG [ 18382 ]
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Mircea Toma added a comment -

        Moved component's page to the correct alphabetical ordered location.

        Show
        Mircea Toma added a comment - Moved component's page to the correct alphabetical ordered location.
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 4.1 [ 11375 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: