ICEfaces
  1. ICEfaces
  2. ICE-10428

ace:autoCompleteEntry XHTML Strict Compliance Issue

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: EE-4.0.0.GA, 4.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces ace:autoCompleteEntry

      Description

      The ace:autoCompleteEntry component uses the following markup structure, which nests a DIV inside of a SPAN, which is technically invalid for xhtml:

      <div id="frm:autoCompleteAccessKey">
                 <span style="display:inline-block;">
                      <input accesskey="c" aria-autocomplete="list" autocomplete="off" class="ui-inputfield ui-widget ui-state-default ui-corner-all ui-state-optional" name="frm:autoCompleteAccessKey_input" onblur="" onfocus="ice.setFocus(this.id);" onmousedown="this.focus();" role="textbox" style="width: 150px;null" type="text" />

       **** <span style="position:relative;display:block;">
       **** <div class="ui-widget ui-widget-content ui-corner-all" id="frm:autoCompleteAccessKey_div"
                       style="display:none;z-index:500;">
                     </div>
                   </span>
                 </span>
                 <script type="text/javascript">
                 </script>
                 <span id="frm:autoCompleteAccessKey_fieldupdate">
                   <script type="text/javascript">
                   </script>
                 </span>
                 <div id="frm:autoCompleteAccessKey_update">
                   <span>
                     <script type="text/javascript">
                     </script>
                   </span>
                 </div>
               </div>


      This JIRA is to modify the markup to not nest a DIV inside a SPAN so improve XHTML compliance.

        Activity

        Ken Fyten created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee Arturo Zambrano [ artzambrano ]
        Fix Version/s EE-4.0.0.GA [ 11171 ]
        Assignee Priority P2 [ 10011 ]
        Arran Mccullough made changes -
        Support Case References Support Case #13207 - https://icesoft.my.salesforce.com/5007000000wKTwo
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43910 Thu Jan 15 09:27:36 MST 2015 art.zambrano ICE-10428 modified markup to comply with XHTML
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenuRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/combobox/combobox.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/selectmenu/selectmenu.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/autocompleteentry/AutoCompleteEntryRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/combobox/ComboBoxRenderer.java
        Hide
        Arturo Zambrano added a comment -

        r43910: modified markup to comply with XHTML.

        Changed divs for spans and adjusted for changes in ace:autoCompleteEntry, ace:comboBox, and ace:selectMenu.

        Show
        Arturo Zambrano added a comment - r43910: modified markup to comply with XHTML. Changed divs for spans and adjusted for changes in ace:autoCompleteEntry, ace:comboBox, and ace:selectMenu.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Arturo Zambrano added a comment -

        Attaching the output of TotalValidator for the AutoCompleteEntryOnly.xhtml page of QA's test app. The component markup doesn't show any XHTML errors.

        Show
        Arturo Zambrano added a comment - Attaching the output of TotalValidator for the AutoCompleteEntryOnly.xhtml page of QA's test app. The component markup doesn't show any XHTML errors.
        Arturo Zambrano made changes -
        Attachment ice10428Validation.html [ 17891 ]
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces4 trunk 4 r43917. Tomcat 7, IE 11, FF 34, Chrome 39. Visual testing ace:autoCompleteEntry, ace:comboBox, and ace:selectMenu in showcase did not find any issues.

        Show
        Liana Munroe added a comment - Verified ICEfaces4 trunk 4 r43917. Tomcat 7, IE 11, FF 34, Chrome 39. Visual testing ace:autoCompleteEntry, ace:comboBox, and ace:selectMenu in showcase did not find any issues.
        Ken Fyten made changes -
        Fix Version/s 4.1 [ 11375 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: