ICEfaces
  1. ICEfaces
  2. ICE-10421

ace:autoCompleteEntry - valueChangeListener not called for first drop down item

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0
          • Fix Version/s: EE-4.0.0.GA, 4.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            The valueChangeListener method for the ace:autoCompleteEntry component is not called in a consistent manner. When displaying values and making a selection, if the first option is selected (via the keyboard or mouse), the change event is not called. An update is sent to the server with the valueChange event but the method is not called. Making a selection of other values calls the method correctly

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case that shows the issue.

              Steps:

              • Load welcomeICEfaces.jsf
              • In the input field enter in '1', a few options are shown. Selecting the first one, there won't be a log in the server logs indicating the VCL is called. If you select the other values, the VCL is called.
              Show
              Arran Mccullough added a comment - Attached test case that shows the issue. Steps: Load welcomeICEfaces.jsf In the input field enter in '1', a few options are shown. Selecting the first one, there won't be a log in the server logs indicating the VCL is called. If you select the other values, the VCL is called.
              Arran Mccullough made changes -
              Field Original Value New Value
              Attachment Case13185Example.war [ 17694 ]
              Attachment Case13185Example.zip [ 17695 ]
              Ken Fyten made changes -
              Summary ace:autoCompleteEntry - valueChaneListener not called for first drop down item ace:autoCompleteEntry - valueChangeListener not called for first drop down item
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ]
              Fix Version/s EE-4.0.0.GA [ 11171 ]
              Assignee Priority P1 [ 10010 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #43881 Thu Jan 08 09:28:03 MST 2015 art.zambrano ICE-10421 added logic to cover case where the selected value is exactly the same as the value typed in the text field, in order to fire a value change listener
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/autocompleteentry/AutoCompleteEntryRenderer.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed fix to 4.0 trunk at revision 43881. The issue didn't have to do with the first item in the list, but with any item that was selected whose value was exactly the same as the value typed in the text field; in the test app this value was '1'. After the fix for ICE-10192, which consisted in setting the submitted value at every request (even if it wasn't a definite submit), the use case where the typed value is exactly the same as the selected value wasn't firing a value change listener. Some logic was added to cover this case and fire a value change listener when this occurs.

              Show
              Arturo Zambrano added a comment - Committed fix to 4.0 trunk at revision 43881. The issue didn't have to do with the first item in the list, but with any item that was selected whose value was exactly the same as the value typed in the text field; in the test app this value was '1'. After the fix for ICE-10192, which consisted in setting the submitted value at every request (even if it wasn't a definite submit), the use case where the typed value is exactly the same as the selected value wasn't firing a value change listener. Some logic was added to cover this case and fire a value change listener when this occurs.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces 4 trunk r43890. Tomcat 7, IE 11, FF 34, Chrome 39.

              Show
              Liana Munroe added a comment - Verified ICEfaces 4 trunk r43890. Tomcat 7, IE 11, FF 34, Chrome 39.
              Ken Fyten made changes -
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: