ICEfaces
  1. ICEfaces
  2. ICE-10416

noSelectionOption doesn't work in ace:selectMenu, ace:comboBox, and ace:simpleSelectOneMenu components

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: EE-4.0.0.GA, 4.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Tested on Tomcat
    • Assignee Priority:
      P1

      Description

      <h:form>
        <ace:simpleSelectOneMenu id="countryIn" value="#{dataBean.country}" required="true">
            <f:selectItem itemValue="" itemLabel="--Select--" noSelectionOption="true"/>
            <f:selectItem itemValue="1" itemLabel="Canada"/>
        </ace:simpleSelectOneMenu>
        <h:message for="countryIn"/>
        <h:commandButton value="Submit" actionListener="#{formBean.submit}"/>
      </h:form>

      When an f:selectItem with noSelectionOption="true" is used as a default value for an ace:simpleSelectOneMenu (with required="true"), if the user selects it and submits the form the field isn't considered invalid. So the noSelectionOption doesn't appear to work with ace:simpleSelectOneMenu.
      This behaviour should be the same as h:selectOneMenu, where we would see the standard validation message ("Required value...").

      Other selection components that use SelectItem's, like ace:selectMenu and ace:comboBox, should also support the noSelectionOption attribute, if appropriate.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43884 Thu Jan 08 13:51:44 MST 2015 art.zambrano ICE-10416 added logic to cover the case where SelectItem's have their label specified but no value
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenuRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/selectmenu/selectmenu.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43804 Tue Dec 09 12:17:45 MST 2014 art.zambrano ICE-10416 fixes for ace:selectMenu and ace:comboBox
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenu.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/combobox/ComboBoxRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43654 Fri Dec 05 14:14:27 MST 2014 art.zambrano ICE-10416 fix to allow submitting null values, mimicking h:selectOneMenu behaviour
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/simpleselectonemenu/SimpleSelectOneMenuRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/simpleselectonemenu/SimpleSelectOneMenu.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43653 Thu Dec 04 17:53:24 MST 2014 art.zambrano ICE-10416 modified logic used to determine whether to mark component invalid or not, depending on whether it is required
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/simpleselectonemenu/SimpleSelectOneMenu.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43643 Wed Dec 03 17:07:37 MST 2014 art.zambrano ICE-10416 added support for noSelectionOption in ace:simpleSelectOneMenu
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/simpleselectonemenu/SimpleSelectOneMenu.java

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Carlo Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: