ICEfaces
  1. ICEfaces
  2. ICE-10394

ace:dataTable - Add keyboard row navigation

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.3, EE-3.3.0.GA_P06
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      Feature Request - With the ice:dataTable it was possible to navigate the rows of a selectable dataTable via the keyboard. The up/down arrow keys could be used to highlight a row and a space bar click would select it. It also has support to allow selection on navigation. This request is to investigate the possibility of adding this feature to the ace:dataTable.

        Issue Links

          Activity

          Arran Mccullough created issue -
          Hide
          Arran Mccullough added a comment -

          Additional functionality requested by the customer:

          If the table has a horizontal scrollbar, it would be nice if the left/right arrow keys scrolled the table horizontally.

          Support for Home/End/PgDown/PgUp would also be nice. For table without a paginator this could scroll the table contents, while for tables with a paginator these keys could cause a page change.

          Show
          Arran Mccullough added a comment - Additional functionality requested by the customer: If the table has a horizontal scrollbar, it would be nice if the left/right arrow keys scrolled the table horizontally. Support for Home/End/PgDown/PgUp would also be nice. For table without a paginator this could scroll the table contents, while for tables with a paginator these keys could cause a page change.
          Ken Fyten made changes -
          Field Original Value New Value
          Fix Version/s 4.1 [ 11375 ]
          Hide
          Ken Fyten added a comment -

          Additional functionality requested by the customer:
          If the table has a horizontal scrollbar, it would be nice if the left/right arrow keys scrolled the table horizontally.
          Support for Home/End/PgDown/PgUp would also be nice. For table without a paginator this could scroll the table contents, while for tables with a paginator these keys could cause a page change.

          Note that these requirements have been met via work done in ICE-10798. However, the original JIRA request for arrow key support to move the selection highlight is still outstanding.

          Show
          Ken Fyten added a comment - Additional functionality requested by the customer: If the table has a horizontal scrollbar, it would be nice if the left/right arrow keys scrolled the table horizontally. Support for Home/End/PgDown/PgUp would also be nice. For table without a paginator this could scroll the table contents, while for tables with a paginator these keys could cause a page change. Note that these requirements have been met via work done in ICE-10798 . However, the original JIRA request for arrow key support to move the selection highlight is still outstanding.
          Ken Fyten made changes -
          Fix Version/s 4.2 [ 12870 ]
          Fix Version/s 4.1 [ 11375 ]
          Ken Fyten made changes -
          Assignee Ken Fyten [ ken.fyten ]
          Ken Fyten made changes -
          Fix Version/s EE-4.2.0.GA [ 13071 ]
          Fix Version/s 4.2 [ 12870 ]
          Ken Fyten made changes -
          Fix Version/s 4.3 [ 13096 ]
          Fix Version/s EE-4.2.0.GA [ 13071 ]
          Ken Fyten made changes -
          Assignee Ken Fyten [ ken.fyten ] Arturo Zambrano [ artzambrano ]
          Hide
          Arturo Zambrano added a comment -

          r521280: added support for highlighting adjacent rows with the up and down arrow keys and for selecting the highlighted row when pressing the space or enter keys, when row selection is enabled

          Also, I verified that for tables with a paginator, the home, end, pgup, and pgdn keys already perform their expected functions. For scrollable tables, those keys also scroll the contents as expected.

          Show
          Arturo Zambrano added a comment - r521280: added support for highlighting adjacent rows with the up and down arrow keys and for selecting the highlighted row when pressing the space or enter keys, when row selection is enabled Also, I verified that for tables with a paginator, the home, end, pgup, and pgdn keys already perform their expected functions. For scrollable tables, those keys also scroll the contents as expected.
          Arturo Zambrano made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #52180 Tue Dec 19 10:05:29 MST 2017 art.zambrano ICE-10394 added support for highlighting adjacent rows with the up and down arrow keys and for selecting the highlighted row when pressing the space or enter keys, when row selection is enabled
          Files Changed
          Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
          Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableMeta.java
          Hide
          Arturo Zambrano added a comment -

          r52187: fixed issue with keyboard row navigation not working with row expansion (as part of ICE-11380)

          Show
          Arturo Zambrano added a comment - r52187: fixed issue with keyboard row navigation not working with row expansion (as part of ICE-11380 )
          Arturo Zambrano made changes -
          Link This issue blocks ICE-11380 [ ICE-11380 ]
          Hide
          Ken Fyten added a comment -

          Re-opened to backport to the 3.3 maintenance branch.

          Show
          Ken Fyten added a comment - Re-opened to backport to the 3.3 maintenance branch.
          Ken Fyten made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Ken Fyten made changes -
          Fix Version/s EE-3.3.0.GA_P07 [ 13118 ]
          Judy Guglielmin made changes -
          Hide
          Ken Fyten added a comment -

          Review Notes

          It would be good if this can be demonstrated in one of the showcase demos.

          Show
          Ken Fyten added a comment - Review Notes It would be good if this can be demonstrated in one of the showcase demos.
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #52431 Thu May 03 13:02:18 MDT 2018 art.zambrano ICE-10394 added code to automatically give focus to the selected/deselected row or cell, in order to be able to navigate the rows or cells from that point
          Files Changed
          Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
          Hide
          Arturo Zambrano added a comment - - edited

          r52431: added code to automatically give focus to the selected/deselected row or cell, in order to be able to navigate the rows or cells from that point

          r52432: added explanation to the ace:dataTable > Selection demo regarding keyboard navigation

          Show
          Arturo Zambrano added a comment - - edited r52431: added code to automatically give focus to the selected/deselected row or cell, in order to be able to navigate the rows or cells from that point r52432: added explanation to the ace:dataTable > Selection demo regarding keyboard navigation
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #52432 Thu May 03 13:23:50 MDT 2018 art.zambrano ICE-10394 added explanation regarding keyboard navigation
          Files Changed
          Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/resources/org/icefaces/samples/showcase/view/resources/messages.properties
          Hide
          Arturo Zambrano added a comment -

          r52436: backported this fix to the EE 3.3 maintenance branch along with ICE-11380

          Show
          Arturo Zambrano added a comment - r52436: backported this fix to the EE 3.3 maintenance branch along with ICE-11380
          Arturo Zambrano made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Judy Guglielmin made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Arturo Zambrano made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Fix Version/s EE-3.3.0.GA_P06 [ 13114 ]
          Fix Version/s EE-3.3.0.GA_P07 [ 13118 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Arran Mccullough
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: