ICEfaces
  1. ICEfaces
  2. ICE-10284

ace:submitMonitor - Modal layer not removed with multiple monitors

          Details

            Description

            When there are multiple ace:submitMonitors in use, one global one and one used for specific components, if the one for the specific component is activated, the global one is also activated. The issue here is that the modal layer for the global one is not removed upon receiving the response.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case that shows this issue.

              Steps:

              • Load welcomeICEfaces.jsf
              • Click on the Open button, a dialog is shown.
              • Click on the Submit button, this executes a long delay and both monitors are shown. Upon receiving the response, the global notification dialog is still shown along with its modal layer.
              Show
              Arran Mccullough added a comment - Attached test case that shows this issue. Steps: Load welcomeICEfaces.jsf Click on the Open button, a dialog is shown. Click on the Submit button, this executes a long delay and both monitors are shown. Upon receiving the response, the global notification dialog is still shown along with its modal layer.
              Arran Mccullough made changes -
              Field Original Value New Value
              Attachment Case12955Example2.war [ 17480 ]
              Attachment Case12955Example2.zip [ 17481 ]
              Ken Fyten made changes -
              Fix Version/s EE-4.0.0.GA [ 11171 ]
              Fix Version/s EE-3.3.0.GA_P03 [ 11572 ]
              Ken Fyten made changes -
              Assignee Mircea Toma [ mircea.toma ]
              Ken Fyten made changes -
              Assignee Priority P2 [ 10011 ]
              Hide
              Permalink
              Arran Mccullough added a comment -

              Ken also suggested that we review how multiple monitors should behave. I have asked the customer on what they would like to see and they responded with the following priority:

              1. Block @none
              2. Block a group or a area
              3. Block @all

              Show
              Arran Mccullough added a comment - Ken also suggested that we review how multiple monitors should behave. I have asked the customer on what they would like to see and they responded with the following priority: 1. Block @none 2. Block a group or a area 3. Block @all
              Hide
              Permalink
              Ken Fyten added a comment -

              New JIRA created: ICE-10313 - "Support 'order of precedence' when multiple ace:submitMonitors active concurrently" for the above.

              Show
              Ken Fyten added a comment - New JIRA created: ICE-10313 - "Support 'order of precedence' when multiple ace:submitMonitors active concurrently" for the above.
              Hide
              Permalink
              Mircea Toma added a comment -

              Pulled out the registration of 'beforeSubmit' and 'afterUpdate' callbacks out of the submit monitor instantiation. Instead register 'beforeSubmit' in order of component instantiation and 'afterSubmit' in reverse order to ensure that each monitor disables and re-enabled its own input element callbacks.

              This fix changes the component so that multiple instances can run in the same page. Initially component was written with the assumption that only one instance is present on the page.

              Show
              Mircea Toma added a comment - Pulled out the registration of 'beforeSubmit' and 'afterUpdate' callbacks out of the submit monitor instantiation. Instead register 'beforeSubmit' in order of component instantiation and 'afterSubmit' in reverse order to ensure that each monitor disables and re-enabled its own input element callbacks. This fix changes the component so that multiple instances can run in the same page. Initially component was written with the assumption that only one instance is present on the page.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #42879 Mon Oct 13 12:11:08 MDT 2014 mircea.toma ICE-10284 Pull the out the registration of 'beforeSubmit' and 'afterUpdate' callbacks out of the submit monitor instantiation. Instead register 'beforeSubmit' in order of component instantiation and 'afterSubmit' in reverse order to ensure that each monitor disables and re-enabled its own input element callbacks.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/submitmonitor/submitmonitor.js
              Mircea Toma made changes -
              Fix Version/s 4.0 [ 11382 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces4 trunk r43877. Tomcat 7, IE 11, FF 34, Chrome 39.

              Show
              Liana Munroe added a comment - Verified ICEfaces4 trunk r43877. Tomcat 7, IE 11, FF 34, Chrome 39.

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: