Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 4.0
-
Fix Version/s: EE-4.0.0.GA, 4.1
-
Component/s: ACE-Components
-
Labels:None
-
Environment:ICEfaces4 trunk rev. 42635
Browser: all
Server: Tomcat 7.0.42
-
Assignee Priority:P2
Description
1) Test page: /listRows.jsf
The following ace:list attributes don't work:
- rows
- rowIndex
- first
This page has an ace:list component with 9 list items, and the attributes are statically defined: rows="3", first="2", rowIndex="3"; these attributes don't appear to affect how the list component is rendered on page.
2) Test page: /listDynAttribute.jsf
Failing attributes:
- controlsItemClass: the default 'ui-state-default ui-corner-all' class is not being applied to the div surrounding the individual reordering icons.
- controlsSpacerClass/ headerClass / footerClass: when updating any of these attributes, the update is not visible on page.
- dragging: list items can still be dragged after disabling this attribute. The 'controlsEnabled' attribute must be switched on or off to disable items dragging.
3) Test page: /listSelectionListenerTest.jsf
- selectionListener - seems to be broken.
4) TLD doc possible error:
- selections: the name of the attribute in the TLD doc is 'selections', of type java.util.Set; however the showcase application > Drag & Drop demo uses 'selection' of type boolean on the ace:list components .Which one is correct?
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
1) Modified renderer to iterate and render over its children that have their index higher or equal that first value and lower than first + rows value. The rowIndex attribute doesn't look like it should have a visual impact since it's just used as a cursor in the backing data model.
2) Fixed control spacer CSS class rendering. Also added header and footer facets to the component so that style changes are visible. Disabled dragging explicitly for list elements.
3) Added 'select' behaviour to ace:list in order to post-back the selection state.
4) The selection attribute is not used, selections refers correctly to the set of objects that are selected in the ace:list component. Removed unused selection attribute from the listDrag.xhtml page.
Tested with ICEfaces 4 trunk r43866. Tomcat 7.
Reopening for 2 issues:
1.) /listDynAttribute.jsf
placeholder and placeholderClass seem to have no impact on the component.
2.) /listRows.jsf . When submitting a selection the following error is seen on the page:
JSON Array[0] is not a number.
class org.icefaces.ace.json.JSONException.
Server error:
WARNING: org.icefaces.ace.json.JSONException: JSONArray[0] is not a number.
javax.faces.FacesException: org.icefaces.ace.json.JSONException: JSONArray[0] is
not a number.
at org.icefaces.ace.component.list.ListRenderer.decode(ListRenderer.java
:91)
at javax.faces.component.UIComponentBase.decode(UIComponentBase.java:831
)
at org.icefaces.impl.component.UISeriesBase.processDecodes(UISeriesBase.
java:523)
at javax.faces.component.UIForm.processDecodes(UIForm.java:225)
at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.
java:1221)
at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.
java:1221)
at javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:929)
at com.sun.faces.lifecycle.ApplyRequestValuesPhase.execute(ApplyRequestV
aluesPhase.java:78)
at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:198)
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:646)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:305)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:210)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperV
alve.java:222)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextV
alve.java:123)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(Authentica
torBase.java:502)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.j
ava:171)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.j
ava:99)
at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:
953)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineVal
ve.java:118)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.jav
a:408)
at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp
11Processor.java:1023)
at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(
AbstractProtocol.java:589)
at org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoin
t.java:1852)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.
java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor
.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.icefaces.ace.json.JSONException: JSONArray[0] is not a number.
at org.icefaces.ace.json.JSONArray.getDouble(JSONArray.java:308)
at org.icefaces.ace.json.JSONArray.getInt(JSONArray.java:325)
at org.icefaces.ace.component.list.ListDecoder.processSelections(ListDec
oder.java:49)
at org.icefaces.ace.component.list.ListRenderer.decode(ListRenderer.java
:74)
... 26 more
Dec 23, 2014 11:01:14 AM org.icefaces.impl.application.ExtendedExceptionHandler
handle
WARNING: queued exception
javax.faces.FacesException: org.icefaces.ace.json.JSONException: JSONArray[0] is
not a number.
at com.sun.faces.lifecycle.ApplyRequestValuesPhase.execute(ApplyRequestV
aluesPhase.java:86)
at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:198)
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:646)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:305)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:210)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperV
alve.java:222)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextV
alve.java:123)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(Authentica
torBase.java:502)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.j
ava:171)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.j
ava:99)
at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:
953)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineVal
ve.java:118)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.jav
a:408)
at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp
11Processor.java:1023)
at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(
AbstractProtocol.java:589)
at org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoin
t.java:1852)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.
java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor
.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: javax.faces.FacesException: org.icefaces.ace.json.JSONException: JSON
Array[0] is not a number.
at org.icefaces.ace.component.list.ListRenderer.decode(ListRenderer.java
:91)
at javax.faces.component.UIComponentBase.decode(UIComponentBase.java:831
)
at org.icefaces.impl.component.UISeriesBase.processDecodes(UISeriesBase.
java:523)
at javax.faces.component.UIForm.processDecodes(UIForm.java:225)
at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.
java:1221)
at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.
java:1221)
at javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:929)
at com.sun.faces.lifecycle.ApplyRequestValuesPhase.execute(ApplyRequestV
aluesPhase.java:78)
... 19 more
Caused by: org.icefaces.ace.json.JSONException: JSONArray[0] is not a number.
at org.icefaces.ace.json.JSONArray.getDouble(JSONArray.java:308)
at org.icefaces.ace.json.JSONArray.getInt(JSONArray.java:325)
at org.icefaces.ace.component.list.ListDecoder.processSelections(ListDec
oder.java:49)
at org.icefaces.ace.component.list.ListRenderer.decode(ListRenderer.java
:74)
... 26 more
Dec 23, 2014 11:01:14 AM com.sun.faces.context.AjaxExceptionHandlerImpl handlePa
rtialResponseError
SEVERE: org.icefaces.ace.json.JSONException: JSONArray[0] is not a number.
at org.icefaces.ace.json.JSONArray.getDouble(JSONArray.java:308)
at org.icefaces.ace.json.JSONArray.getInt(JSONArray.java:325)
at org.icefaces.ace.component.list.ListDecoder.processSelections(ListDec
oder.java:49)
at org.icefaces.ace.component.list.ListRenderer.decode(ListRenderer.java
:74)
at javax.faces.component.UIComponentBase.decode(UIComponentBase.java:831
)
at org.icefaces.impl.component.UISeriesBase.processDecodes(UISeriesBase.
java:523)
at javax.faces.component.UIForm.processDecodes(UIForm.java:225)
at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.
java:1221)
at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.
java:1221)
at javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:929)
at com.sun.faces.lifecycle.ApplyRequestValuesPhase.execute(ApplyRequestV
aluesPhase.java:78)
at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:198)
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:646)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:305)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:210)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperV
alve.java:222)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextV
alve.java:123)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(Authentica
torBase.java:502)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.j
ava:171)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.j
ava:99)
at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:
953)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineVal
ve.java:118)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.jav
a:408)
at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp
11Processor.java:1023)
at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(
AbstractProtocol.java:589)
at org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoin
t.java:1852)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.
java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor
.java:615)
at java.lang.Thread.run(Thread.java:745)
1) Fixed placeholder styling.
2) Fixed ice.ace.List.prototype.getUnshiftedIndex function to work even when no reordering has been applied to the list.
Verified ICEfaces4 trunk r43872. Tomcat 7, IE 11, FF 34, Chrome 39.
IF4 trunk rev. 43887 and 43871:
showcase > list > Drag & Drop:
Demo is not functional (all browsers):
1) on the upper demo, after dragging an item, the change is not submitted;
2) on the "Two-Way Drag Migrations demo, the items cannot be dragged between the 2 panels; only dragging inside the same panel works.
No such issues on rev. 43858, prior to the commits for this JIRA.
Wired jQuery's 'start', 'stop' and 'receive' callbacks to the sortable container. Also enabled 'connectWith' property on sortable container. See http://api.jqueryui.com/sortable/ .
Testing results with IF4 trunk r. 43899, browsers: FF34, IE11, CHrome39:
showcase > ace:list > Drag & Drop demo issue has been resolved.
ace:list QA test application > /listDynAttribute.jsf test fails.
A JS error occurs when selecting placeholderClass=customStyle and clicking on a list item to drag it.
Firefox34:
TypeError: options.connectWith is undefined
http://localhost:8080/list/javax.faces.resource/util/ace-jquery-ui.uncompressed.js.jsf?ln=icefaces.ace&v=4_1_0_150113
Line 3827
IE11:
SCRIPT5007: Unable to get property 'constructor' of undefined or null reference
File: ace-jquery-ui.uncompressed.js.jsf, Line: 3827, Column: 13
Steps:
- build/deploy the app from: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/list
- load the /listDynAttribute.jsf page in any browser.
- select selectionMode=single, and placeHolderClass=customStyle.
- click on a list item -> JS error.
Add 'connectWith' option to the sortable JS object only if its value is defined
Verified ICEfaces4 trunk r43909. Tomcat 7, IE 11, FF 34, Chrome 39.
Liana reports: