ICEfaces
  1. ICEfaces
  2. ICE-10229

ace:listControl - headerClass, footerClass attributes don't work

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: EE-4.0.0.GA, 4.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      IF4 trunk rev. 42519
      Browsers: all
      Server: Tomcat7.0.42
    • Assignee Priority:
      P2

      Description

      On the DynamciAttribute test page, when updating any of the two attributes, the updates are not visible on the page.

      QA test app for ace:controlList:
      http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/listControl

      Dynamic attribute test: //listControlDynAttribute.jsf


        Activity

        Carmen Cristurean created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee Judy Guglielmin [ judy.guglielmin ]
        Security Private [ 10001 ]
        Fix Version/s EE-4.0.0.GA [ 11171 ]
        Affects Version/s 3.3 [ 10370 ]
        Affects Version/s 4.0 [ 11382 ]
        Priority Major [ 3 ] Minor [ 4 ]
        Assignee Priority P2 [ 10011 ]
        Hide
        Carmen Cristurean added a comment -

        Using: <f:ajax execute="@this" render="@all"/> instead of: onclick="ice.se(event, this); does not change how the test functions.

        Show
        Carmen Cristurean added a comment - Using: <f:ajax execute="@this" render="@all"/> instead of: onclick="ice.se(event, this); does not change how the test functions.
        Hide
        Mircea Toma added a comment - - edited

        I modified the test to run with onclick="ice.se(event, this); as before. I'm not seeing any issue with ice.se. It sends execute and render parameters as expected. Here are the submit parameters:

        ice.event.alt	false
        ice.event.captured	renderedForm:headerClass
        ice.event.ctrl	false
        ice.event.left	true
        ice.event.meta	false
        ice.event.right	false
        ice.event.shift	false
        ice.event.target	
        ice.event.type	onclick
        ice.event.x	167
        ice.event.y	425
        ice.focus	
        ice.submit.serialization	element
        ice.submit.type	ice.se
        ice.view	3hzvt5oiq:1o0x
        ice.view	3hzvt5oiq:1o0x
        ice.window	70hzvt42s7
        ice.window	70hzvt42s7
        javax.faces.ClientWindow	70hzvt42s7
        javax.faces.ViewState	4095834092751750795:6853021613036645079
        javax.faces.partial.ajax	true
        javax.faces.partial.event	click
        javax.faces.partial.execute	renderedForm:headerClass
        javax.faces.partial.render	@all
        javax.faces.source	renderedForm:headerClass
        renderedForm:headerClass	customGreenBackground
        v3hzvt5oiq-1o0x-single-su...	v3hzvt5oiq-1o0x-single-submit
        
        Show
        Mircea Toma added a comment - - edited I modified the test to run with onclick="ice.se(event, this); as before. I'm not seeing any issue with ice.se . It sends execute and render parameters as expected. Here are the submit parameters: ice.event.alt false ice.event.captured renderedForm:headerClass ice.event.ctrl false ice.event.left true ice.event.meta false ice.event.right false ice.event.shift false ice.event.target ice.event.type onclick ice.event.x 167 ice.event.y 425 ice.focus ice.submit.serialization element ice.submit.type ice.se ice.view 3hzvt5oiq:1o0x ice.view 3hzvt5oiq:1o0x ice.window 70hzvt42s7 ice.window 70hzvt42s7 javax.faces.ClientWindow 70hzvt42s7 javax.faces.ViewState 4095834092751750795:6853021613036645079 javax.faces.partial.ajax true javax.faces.partial.event click javax.faces.partial.execute renderedForm:headerClass javax.faces.partial.render @all javax.faces.source renderedForm:headerClass renderedForm:headerClass customGreenBackground v3hzvt5oiq-1o0x-single-su... v3hzvt5oiq-1o0x-single-submit
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #42539 Tue Sep 09 17:18:07 MDT 2014 judy.guglielmin ICE-10229 added in facets to Meta and tlddocs to show that headerClass and headerStyle only apply if the header facet is present (same as footer). Updated test to use the facets
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/listcontrol/ListControlMeta.java
        Hide
        Judy Guglielmin added a comment -

        added in facets so the attributes can be applied

        Show
        Judy Guglielmin added a comment - added in facets so the attributes can be applied
        Judy Guglielmin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Carmen Cristurean added a comment -

        Verified with IF4 trunk rev. 42540 in IE10, Chrome37 and FF31.

        Show
        Carmen Cristurean added a comment - Verified with IF4 trunk rev. 42540 in IE10, Chrome37 and FF31.
        Judy Guglielmin made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Judy Guglielmin [ judy.guglielmin ] Arturo Zambrano [ artzambrano ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43908 Wed Jan 14 16:59:16 MST 2015 art.zambrano ICE-10229 added ui-state-default class to header and footer
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/listcontrol/ListControlRenderer.java
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43912 Thu Jan 15 13:51:58 MST 2015 art.zambrano ICE-10229 changed precedence of custom and default classes, so that custom classes have more precendence
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/listcontrol/ListControlRenderer.java
        Hide
        Arturo Zambrano added a comment -

        r43912: changed precedence of custom and default classes, so that custom classes have more precendence.

        Show
        Arturo Zambrano added a comment - r43912: changed precedence of custom and default classes, so that custom classes have more precendence.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43914 Thu Jan 15 14:47:39 MST 2015 art.zambrano ICE-10229 missing space between default and custom CSS classes
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/listcontrol/ListControlRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43917 Thu Jan 15 15:30:55 MST 2015 art.zambrano ICE-10229 fix to center header and footer text when the lists are inside the controls
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/listcontrol/listcontrol.css
        Hide
        Liana Munroe added a comment -

        Verified Header/footerClass issue ICEfaces 4 trunk r43916. Tomcat 7, FF 34, Chrome 39, IE 11. Updated the test application in order to make the class changes work properly. In the process I also reorganized the test application to include the list between the listControl header and footer facets. Previously the list was set outside of the facets. Now that the list is between the header and footer, the text in the header and footer facets is no longer centered. See attached screenshot.
        Test app /listControlDynAttribute.jsf located at:
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/listControl

        Show
        Liana Munroe added a comment - Verified Header/footerClass issue ICEfaces 4 trunk r43916. Tomcat 7, FF 34, Chrome 39, IE 11. Updated the test application in order to make the class changes work properly. In the process I also reorganized the test application to include the list between the listControl header and footer facets. Previously the list was set outside of the facets. Now that the list is between the header and footer, the text in the header and footer facets is no longer centered. See attached screenshot. Test app /listControlDynAttribute.jsf located at: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/listControl
        Liana Munroe made changes -
        Attachment listControl.PNG [ 17890 ]
        Hide
        Liana Munroe added a comment -

        Verified facet text centering issue ICEfaces 4 trunk r43917. Tomcat 7, FF 34, Chrome 39, IE 11.

        Show
        Liana Munroe added a comment - Verified facet text centering issue ICEfaces 4 trunk r43917. Tomcat 7, FF 34, Chrome 39, IE 11.
        Ken Fyten made changes -
        Fix Version/s 4.1 [ 11375 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Carmen Cristurean
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: