ICEfaces
  1. ICEfaces
  2. ICE-10191

ace:dialog - Modal layer not removed when setting visible=false

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0.BETA, 4.0
          • Fix Version/s: 4.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            When closing an ace:dialog by setting its visible property to false, the modal layer is not removed from the page.

            If the Close button in the header is rendered then clicking this will remove the modal layer.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case that shows the issue.

              Steps:

              • Load welcomeICEfaces.jsf
              • Click the Open button
              • The modal dialog is shown. There are two buttons (ace:pushButton and h:commandButton), clicking on either one will have the dialog removed but the modal layer stays.
              Show
              Arran Mccullough added a comment - Attached test case that shows the issue. Steps: Load welcomeICEfaces.jsf Click the Open button The modal dialog is shown. There are two buttons (ace:pushButton and h:commandButton), clicking on either one will have the dialog removed but the modal layer stays.
              Arran Mccullough made changes -
              Field Original Value New Value
              Attachment Case13005Example.war [ 17334 ]
              Attachment Case13005Example.zip [ 17335 ]
              Ken Fyten made changes -
              Assignee Mircea Toma [ mircea.toma ]
              Fix Version/s 4.0 [ 11382 ]
              Assignee Priority P1 [ 10010 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #42330 Fri Aug 29 10:35:23 MDT 2014 mircea.toma ICE-10191 Close dialog when dialog's updated markup is made invisible.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js
              Hide
              Permalink
              Mircea Toma added a comment -

              Close dialog when dialog's updated markup is made invisible.

              Show
              Mircea Toma added a comment - Close dialog when dialog's updated markup is made invisible.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Tested with IF4 trunk rev. 42336 in IE10, Chrome36, FF31, I cannot get it working with the attached test app.

              Show
              Carmen Cristurean added a comment - Tested with IF4 trunk rev. 42336 in IE10, Chrome36, FF31, I cannot get it working with the attached test app.
              Carmen Cristurean made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              Please try using the attached WAR file and just replace icefaces.jar and icefaces-ace.jar libraries.

              Show
              Mircea Toma added a comment - - edited Please try using the attached WAR file and just replace icefaces.jar and icefaces-ace.jar libraries.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #42491 Tue Sep 02 15:37:59 MDT 2014 mircea.toma ICE-10191 Removed test for dialog's visibility because onElementUpdate callbacks are invoked before the update that changes the visibility is applied.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              Applied additional fix that removes the test for dialog's visibility. onElementUpdate callbacks are invoked before the update that changes the visibility is applied, so the test runs too early.

              Show
              Mircea Toma added a comment - - edited Applied additional fix that removes the test for dialog's visibility. onElementUpdate callbacks are invoked before the update that changes the visibility is applied, so the test runs too early.
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified with ICEfaces4 trunk rev. 42491 in FF31, IE10, Chrome36.

              Show
              Carmen Cristurean added a comment - Verified with ICEfaces4 trunk rev. 42491 in FF31, IE10, Chrome36.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: