ICEfaces
  1. ICEfaces
  2. ICE-10183

icecore:defaultAction does not capture all keyboard events in some browsers

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.BETA
    • Fix Version/s: 4.0, EE-3.3.0.GA_P06
    • Component/s: None
    • Labels:
      None
    • Environment:
      Chrome, IE 8/9/10

      Description

      icecore:defaultAction does not capture all keyboard events in some browsers such as _Esc_ and _F..._ keys.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #42156 Mon Aug 25 13:30:44 MDT 2014 mircea.toma ICE-10183 Register callback with 'onkeydown' instead of 'onkeypress' event to make sure all the keys are captured.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/javascript/capture-submit.js
        Mircea Toma created issue -
        Mircea Toma made changes -
        Field Original Value New Value
        Assignee Mircea Toma [ mircea.toma ]
        Mircea Toma made changes -
        Affects Version/s 4.0.BETA [ 10770 ]
        Mircea Toma made changes -
        Fix Version/s 4.0 [ 11382 ]
        Hide
        Mircea Toma added a comment -

        Register callback with onkeydown instead of onkeypress event to make sure all the keys are captured. Browsers like Chrome and IE will not fire keypress events for keys that are meant to control the browser.

        Show
        Mircea Toma added a comment - Register callback with onkeydown instead of onkeypress event to make sure all the keys are captured. Browsers like Chrome and IE will not fire keypress events for keys that are meant to control the browser.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Many of the keyboard events are now captured but when using some of them, the default browser action is also fired. For example, submitting with the F3 key works, but it also launches the browser's "Find" dialog. Submitting with the F2 key works, but it also launches the browser's "Help" dialog. These are just 2 examples of this occurring, there are more. Is this expected behaviour?

        Show
        Liana Munroe added a comment - Many of the keyboard events are now captured but when using some of them, the default browser action is also fired. For example, submitting with the F3 key works, but it also launches the browser's "Find" dialog. Submitting with the F2 key works, but it also launches the browser's "Help" dialog. These are just 2 examples of this occurring, there are more. Is this expected behaviour?
        Hide
        Ken Fyten added a comment -

        I wonder if the jsEventListener should consume the event after it processes it? This might not stop the browser from doing what it wants though, in which case we should just use different keys for the example/demo and avoid any that have native browser functions.

        Show
        Ken Fyten added a comment - I wonder if the jsEventListener should consume the event after it processes it? This might not stop the browser from doing what it wants though, in which case we should just use different keys for the example/demo and avoid any that have native browser functions.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Arturo Zambrano added a comment -

        r52745: backported fix to the EE 3.3 maintenance branch

        Show
        Arturo Zambrano added a comment - r52745: backported fix to the EE 3.3 maintenance branch
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Ken Fyten made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Fix Version/s EE-3.3.0.GA_P06 [ 13114 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Mircea Toma
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: