ICEfaces
  1. ICEfaces
  2. ICE-10165

The actionListeners on the ace:breadcrumbMenu no longer work.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.BETA
    • Fix Version/s: 4.0
    • Component/s: ACE-Components, Sample Apps
    • Labels:
      None
    • Environment:
      ACE Components
    • Assignee Priority:
      P1

      Description

      Looks like work done for ICE-10132 has lead to a problem with the ace:breadcrumbMenu in the showcase. If you click on some items in the tree to create a menu, clicking on the menu items with attached actionListeners does not appear to do anything.

        Activity

        Deryk Sinotte created issue -
        Hide
        Deryk Sinotte added a comment -

        From my testing, it looks like it was broken @ revision 41818:

        ------------------------------------------------------------------------
        r41818 | art.zambrano | 2014-07-17 14:12:04 -0700 (Thu, 17 Jul 2014) | 1 line
        
        ICE-10132 changed default ajax execute values from @all to @this and changed ice.s() calls for ice.se() calls in various components
        ------------------------------------------------------------------------
        
        From ICE-10132, I don't see the breadcrumb menu in the list of stuff that was tested or changed but the repository shows that some common menu code may have been impacted:
        
        U    ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonMeta.java
        U    ace/component/src/org/icefaces/ace/component/maskedentry/MaskedEntryMeta.java
        U    ace/component/src/org/icefaces/ace/component/menu/BaseMenuRenderer.java
        U    ace/component/src/org/icefaces/ace/component/linkbutton/LinkButtonMeta.java
        U    ace/component/src/org/icefaces/ace/component/radiobutton/RadioButtonMeta.java
        U    ace/component/src/org/icefaces/ace/component/printer/PrinterMeta.java
        U    ace/component/src/org/icefaces/ace/component/menuitem/MenuItemMeta.java
        U    ace/component/resources/icefaces.ace/richtextentry/richtextentry.js
        U    ace/component/resources/icefaces.ace/autocompleteentry/autocompleteentry.js
        
        Show
        Deryk Sinotte added a comment - From my testing, it looks like it was broken @ revision 41818: ------------------------------------------------------------------------ r41818 | art.zambrano | 2014-07-17 14:12:04 -0700 (Thu, 17 Jul 2014) | 1 line ICE-10132 changed default ajax execute values from @all to @this and changed ice.s() calls for ice.se() calls in various components ------------------------------------------------------------------------ From ICE-10132, I don't see the breadcrumb menu in the list of stuff that was tested or changed but the repository shows that some common menu code may have been impacted: U ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonMeta.java U ace/component/src/org/icefaces/ace/component/maskedentry/MaskedEntryMeta.java U ace/component/src/org/icefaces/ace/component/menu/BaseMenuRenderer.java U ace/component/src/org/icefaces/ace/component/linkbutton/LinkButtonMeta.java U ace/component/src/org/icefaces/ace/component/radiobutton/RadioButtonMeta.java U ace/component/src/org/icefaces/ace/component/printer/PrinterMeta.java U ace/component/src/org/icefaces/ace/component/menuitem/MenuItemMeta.java U ace/component/resources/icefaces.ace/richtextentry/richtextentry.js U ace/component/resources/icefaces.ace/autocompleteentry/autocompleteentry.js
        Deryk Sinotte made changes -
        Field Original Value New Value
        Assignee Mircea Toma [ mircea.toma ]
        Fix Version/s 4.0 [ 11382 ]
        Assignee Priority P1 [ 10010 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #42084 Thu Aug 07 12:25:52 MDT 2014 mircea.toma ICE-10165 Rolled back the previous change to make actionListeners work again.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/BaseMenuRenderer.java
        Hide
        Mircea Toma added a comment -

        Rolled back the previous change for BaseMenuRenderer to use ice.s again. It seems that the tree component needs to execute as well so that the actionListeners are invoked.

        Show
        Mircea Toma added a comment - Rolled back the previous change for BaseMenuRenderer to use ice.s again. It seems that the tree component needs to execute as well so that the actionListeners are invoked.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Verified Icefaces 4 trunk r42085. Tomcat 7, all browsers.

        Show
        Liana Munroe added a comment - Verified Icefaces 4 trunk r42085. Tomcat 7, all browsers.
        Hide
        Liana Munroe added a comment - - edited

        Reopening because of a new issue with Breadcrumbs with URLs. After navigating to the page link in the Breadcrumb with URL, then using the Back button on the browser the province nodes cannot be opened up again (all browsers).
        Steps:

        • expand a province menu, as example Manitoba, by clicking the "+" sign -> city menu items are rendered underneath;
        • click on a city, as example Winnipeg -> the crumbs are rendered on the right side of the page: Canada > Manitoba > Winnipeg.
        • click on the province name (Manitoba) in the "Crumbs with URL's" menu -> the page is redirected to the wikipedia page for Manitoba.
        • click back in the browser to navigate back to the showcase breadcrumbMenu page -> page redirection is completed.
        • click on another "+" sign to open up the menuItem tags for a province -> this step fails.
          Sometimes, when trying to open another province node, the Mobi Components tab is enabled and the content of the page disappears. See Screenshot Breadcrumb.PNG
        Show
        Liana Munroe added a comment - - edited Reopening because of a new issue with Breadcrumbs with URLs. After navigating to the page link in the Breadcrumb with URL, then using the Back button on the browser the province nodes cannot be opened up again (all browsers). Steps: expand a province menu, as example Manitoba, by clicking the "+" sign -> city menu items are rendered underneath; click on a city, as example Winnipeg -> the crumbs are rendered on the right side of the page: Canada > Manitoba > Winnipeg. click on the province name (Manitoba) in the "Crumbs with URL's" menu -> the page is redirected to the wikipedia page for Manitoba. click back in the browser to navigate back to the showcase breadcrumbMenu page -> page redirection is completed. click on another "+" sign to open up the menuItem tags for a province -> this step fails. Sometimes, when trying to open another province node, the Mobi Components tab is enabled and the content of the page disappears. See Screenshot Breadcrumb.PNG
        Liana Munroe made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Liana Munroe made changes -
        Attachment breadcrumb.png [ 17330 ]
        Hide
        Mircea Toma added a comment - - edited

        I cannot reproduce this last problem. I used Chrome, Firefox and Safari.

        Show
        Mircea Toma added a comment - - edited I cannot reproduce this last problem. I used Chrome, Firefox and Safari.
        Hide
        Ken Fyten added a comment -

        I am able to reproduce this sporadically (about half the time) using the latest jenkins build of ICEfaces4/trunk svn rvn#42156 (Chrome).

        Sometimes when the clicking the Province in the tree fails to expand it, it will instead navigate to the top-level ACE Components overview for some reason.

        Show
        Ken Fyten added a comment - I am able to reproduce this sporadically (about half the time) using the latest jenkins build of ICEfaces4/trunk svn rvn#42156 (Chrome). Sometimes when the clicking the Province in the tree fails to expand it, it will instead navigate to the top-level ACE Components overview for some reason.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #42335 Mon Sep 01 17:09:59 MDT 2014 mircea.toma ICE-10165 Changed CachingHeaderPhaseListener into a system event listener to make sure the no-cache headers are setup after the navigation notifier has a chance to render.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/impl/component/NavigationNotifier.java
        Commit graph DEL /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/util/CachingHeaderPhaseListener.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/impl/component/NavigationNotifierHandler.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/resources/META-INF/faces-config.xml
        Commit graph ADD /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/util/CachingHeadersSetup.java
        Hide
        Mircea Toma added a comment -

        This issue seems to be a regression caused by the commits made for ICE-10116. When running the showcase application the no-caching headers are not properly sent anymore. This makes the browser not re-evaluate the inline scripts when navigating with the back button.

        Show
        Mircea Toma added a comment - This issue seems to be a regression caused by the commits made for ICE-10116 . When running the showcase application the no-caching headers are not properly sent anymore. This makes the browser not re-evaluate the inline scripts when navigating with the back button .
        Hide
        Mircea Toma added a comment -

        Changed CachingHeaderPhaseListener into a system event listener to make sure the no-cache headers are setup after the navigation notifier has a chance to render.

        Show
        Mircea Toma added a comment - Changed CachingHeaderPhaseListener into a system event listener to make sure the no-cache headers are setup after the navigation notifier has a chance to render.
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Carmen Cristurean added a comment -

        Verified with IF4 trunk rev. 42335/42487 in FF31, IE10, Chrome36.

        Show
        Carmen Cristurean added a comment - Verified with IF4 trunk rev. 42335/42487 in FF31, IE10, Chrome36.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: