ICEfaces
  1. ICEfaces
  2. ICE-10055

ace:column - Add new "sortWhenGrouping" boolean attribute to optionally support grouping without sorting

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P01, 4.0.BETA
          • Fix Version/s: EE-4.0.0.GA, EE-3.3.0.GA_P03, 4.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            Feature Request: Currently when groupBy is used it will render the column as being sorted. This request is to add a way to not display the sort icons when just groupBy is used. A valid use case would be if a tables contents should be displayed as grouped but sorting is not a requirement.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Fix Version/s EE-4.0.0.GA [ 11171 ]
              Fix Version/s EE-3.3.0.GA_P03 [ 11572 ]
              Fix Version/s 4.1 [ 11375 ]
              Hide
              Permalink
              Rahul Chaudhary added a comment -

              Hello,

              This issue has been inactive for days. Has there been an update on this ?

              I am also having problems with group by in lazily loaded tables. When I try to do a groupby, I get a heap exception that my memory is full. I am not sure if this is icefaces issue or my code issue, but I would be more certain if this issue has been fixed.

              Thank You.

              Show
              Rahul Chaudhary added a comment - Hello, This issue has been inactive for days. Has there been an update on this ? I am also having problems with group by in lazily loaded tables. When I try to do a groupby, I get a heap exception that my memory is full. I am not sure if this is icefaces issue or my code issue, but I would be more certain if this issue has been fixed. Thank You.
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ]
              Assignee Priority P2 [ 10011 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #43814 Thu Dec 11 15:40:16 MST 2014 art.zambrano ICE-10055 added 'sortWhenGrouping' attribute to ace:column to disable automatic sorting when using groupBy
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTable.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/column/ProxiedBodyColumn.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/column/Column.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/column/ColumnMeta.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed new feature to 4.0 trunk at revision 43814 and to 3.3 EE maintenance branch at revision 43815. Added 'sortWhenGrouping' attribute to ace:column to disable automatic sorting when using groupBy.

              Show
              Arturo Zambrano added a comment - Committed new feature to 4.0 trunk at revision 43814 and to 3.3 EE maintenance branch at revision 43815. Added 'sortWhenGrouping' attribute to ace:column to disable automatic sorting when using groupBy.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Summary ace:column - Add option to not show a column as sorted when using groupBy ace:column - Add new "sortWhenGrouping" boolean attribute to optionally support grouping without sorting
              Hide
              Permalink
              Liana Munroe added a comment -

              Tested with ICEfaces 4 trunk and ee-3.3.0 maintenance branch r43821.
              The test application is set up with 2 columns that each have sortWhenGrouping=true. When first arriving at the page the columns can be sorted. After setting the controls to be hidden, then back to shown, the columns can no longer be sorted unless the Name column is sorted or the page is refreshed.
              QA test apps: /ICE-10055.jsf
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/dataTable/web/views
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/dataTable/web/views

              Show
              Liana Munroe added a comment - Tested with ICEfaces 4 trunk and ee-3.3.0 maintenance branch r43821. The test application is set up with 2 columns that each have sortWhenGrouping=true. When first arriving at the page the columns can be sorted. After setting the controls to be hidden, then back to shown, the columns can no longer be sorted unless the Name column is sorted or the page is refreshed. QA test apps: / ICE-10055 .jsf http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/dataTable/web/views http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/dataTable/web/views
              Liana Munroe made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #43826 Tue Dec 16 11:59:32 MST 2014 art.zambrano ICE-10426, ICE-10055 added logic to re-apply all the event listeners to the sort controls whenever they're updated
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableHeadRenderer.java
              Hide
              Permalink
              Arturo Zambrano added a comment - - edited

              Added logic to re-apply all the event listeners to the sort controls whenever they're updated in the client (at revisions 43826 and 43827).

              Show
              Arturo Zambrano added a comment - - edited Added logic to re-apply all the event listeners to the sort controls whenever they're updated in the client (at revisions 43826 and 43827).
              Arturo Zambrano made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Tested with ICEfaces 4 trunk r43829. Tomcat 7, IE 11, FF 33, Chrome 39. Issue still remains, after setting the controls to be hidden, then back to shown, the columns can no longer be sorted unless the Name column is sorted or the page is refreshed.

              Show
              Liana Munroe added a comment - Tested with ICEfaces 4 trunk r43829. Tomcat 7, IE 11, FF 33, Chrome 39. Issue still remains, after setting the controls to be hidden, then back to shown, the columns can no longer be sorted unless the Name column is sorted or the page is refreshed.
              Liana Munroe made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Ken Fyten made changes -
              Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #43851 Fri Dec 19 10:00:20 MST 2014 art.zambrano ICE-10055 fix for issue with not being able to sort column after turning 'sortWhenGrouping' off and back on
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableHeadRenderer.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed fix for issue with not being able to sort column after turning 'sortWhenGrouping' off and back on at revisions 43851 and 43852.

              Show
              Arturo Zambrano added a comment - Committed fix for issue with not being able to sort column after turning 'sortWhenGrouping' off and back on at revisions 43851 and 43852.
              Arturo Zambrano made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces4 trunk r43852, Tomcat 7, IE 11, FF 33, Chrome 39.
              Unable to verify using ee-3.3.0 maintenance branch at this time as there other issues with dataTable that may be interfering.

              Show
              Liana Munroe added a comment - Verified ICEfaces4 trunk r43852, Tomcat 7, IE 11, FF 33, Chrome 39. Unable to verify using ee-3.3.0 maintenance branch at this time as there other issues with dataTable that may be interfering.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Changed use of ice.ace.instance for widgetVar in 3.3 EE maintenance branch at revision 43853.

              Show
              Arturo Zambrano added a comment - Changed use of ice.ace.instance for widgetVar in 3.3 EE maintenance branch at revision 43853.
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces ee-3.3.0 maintenance branch r43860. Tomcat 7, IE 11, FF 34, Chrome 39.

              Show
              Liana Munroe added a comment - Verified ICEfaces ee-3.3.0 maintenance branch r43860. Tomcat 7, IE 11, FF 34, Chrome 39.
              Ken Fyten made changes -
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: